On 07/03/2018 10:58 AM, Paul Eggleton wrote:
Hi Robert
On Tuesday, 3 July 2018 2:45:11 PM NZST Robert Yang wrote:
Thanks for let me know this, this patch might be incorrect, suppose we have two
layers: core and hello:
1) LAYERRECOMMENDS_core = "hello"
2) $ update.py -l hello,core
Then core maybe added before hello layer since it ignores recs on hello, and if
hello is a new layer, it would not be in core's recs in database since core
knows nothing about hello, I think that this is incorrect.
If we really need this, I think that we should not ignore recs when the
layer is present, but only ignore it when the layer is not present, for
example, ignore it when hello layer doesn't exist, otherwise, don't ignore it.
Can you come up with an alternative fix that doesn't break parsing like it does
now?
OK, I will, maybe I can send you a patch by tomorrow, but I'm not sure since
the implementation might be a little complicated.
// Robert
But I'm not sure about patch 4 (error -> warning) either, since layerindex is
a central database, whether add recs to conf/bblayers.conf should depend on
end user rather than ignore it in database, otherwise the end user (especially
the api user) would have no way to choice, for example, we use api to make
conf/bblayers.conf have all or no recs layers according to user's choice,
if the database is wrong, then there might be only part of recs layers.
Though we can check update.py's warnings to fix the problem.
Recommends are just that - recommendations. Someone might legitimately
submit a layer that recommends another which they don't submit (perhaps a
commercial layer?). The system shouldn't refuse to handle it or indicate that
it's broken (it isn't, there might be reduced functionality but the layer will
still
be parseable by bitbake).
I'll leave these changes unmerged for a bit in case you have a better fix for
the current problems.
Cheers,
Paul
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
