Thanks Juro. I'll remember to keep an eye out for the ifdefs disappearing.
Ross On 13 April 2018 at 15:46, Bystricky, Juro <juro.bystri...@intel.com> wrote: > yes, I've done it before: > https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742 > I'll do it gain. Hopefully it will last longer this time. > > > ________________________________________ > From: Burton, Ross [ross.bur...@intel.com] > Sent: Friday, April 13, 2018 5:50 AM > To: Bystricky, Juro > Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis > Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken > qemu build for mingw > > Is it feasible to fix the original patch? > > Ross > > On 13 April 2018 at 00:55, Juro Bystricky <juro.bystri...@intel.com> wrote: >> The commit "qemu: Bump to version 2.11.0" in oe-core broke the >> build of qemu for mingw, due to using "socketpair", which is >> not supported by mingw. "socketpair" is used in a local patch, >> not in the qemu upstream code. The original local patch had >> conditional code to exclude "socketpair" for _WIN32, but the >> modified patch for qemu 2.11.0 removed this. >> >> The fix is to simply remove the offending patch. >> >> Signed-off-by: Juro Bystricky <juro.bystri...@intel.com> >> --- >> recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++ >> 1 file changed, 4 insertions(+) >> create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend >> >> diff --git a/recipes-devtools/qemu/qemu_2.11.%.bbappend >> b/recipes-devtools/qemu/qemu_2.11.%.bbappend >> new file mode 100644 >> index 0000000..764b500 >> --- /dev/null >> +++ b/recipes-devtools/qemu/qemu_2.11.%.bbappend >> @@ -0,0 +1,4 @@ >> + >> + >> +SRC_URI_remove_mingw32 = >> "file://chardev-connect-socket-to-a-spawned-command.patch" >> + >> -- >> 2.7.4 >> >> -- >> _______________________________________________ >> yocto mailing list >> yocto@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/yocto -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
