On Thu, Jul 6, 2017 at 3:46 PM, Minchev, Todor <todor.minc...@intel.com> wrote: > On Thu, 2017-07-06 at 13:46 -0700, Todor Minchev wrote: >> On Thu, 2017-07-06 at 13:37 -0700, Khem Raj wrote: >> > On Thu, Jul 6, 2017 at 1:08 PM, Todor Minchev >> > <todor.minc...@linux.intel.com> wrote: >> > > On Wed, 2017-07-05 at 12:39 -0700, swee.aun.k...@intel.com wrote: >> > >> From: sweeaun <swee.aun.k...@intel.com> >> > >> >> > >> RMC efi is needed to compiled as 64 bits even DEFAULTTUNE is x32. >> > >> >> > >> Signed-off-by: sweeaun <swee.aun.k...@intel.com> >> > >> --- >> > >> Makefile.efi | 3 +++ >> > >> 1 file changed, 3 insertions(+) >> > >> >> > >> diff --git a/Makefile.efi b/Makefile.efi >> > >> index 4f69dfe..95e0f8c 100644 >> > >> --- a/Makefile.efi >> > >> +++ b/Makefile.efi >> > >> @@ -16,6 +16,9 @@ RMC_INSTALL_LIB_PATH := $(RMC_INSTALL_PREFIX)/lib/ >> > >> >> > >> RMC_CFLAGS := -DRMC_EFI -Wall -I$(TOPDIR)/inc -fpic -nostdinc >> > >> -nostdlib -fno-builtin -std=gnu90 >> > >> >> > >> +#RMC efi is needed to be compiled as 64 bit even DEFAULTTUNE is x32 >> > >> +CC := $(patsubst -mx32, -m64, $(CC)) >> > >> + >> > > >> > >> > does this mean package is overriding CC passed from env ? >> > if yes then I think app should be fixed to respect CC if set in env >> > and only set it if CC env is not set >> >> +1 >> >> The app respects both CC and CFLAGS from the env. They have to be set to >> the correct values before the Makefile is called. >> >> > >> > > Since this is not an RMC-specific problem, I believe that we shouldn't >> > > patch the compiler flags in the RMC Makefile. This patch will provide >> > > the desired outcome only when RMC is built with meta-intel. A better >> > > alternative will be to split rmc.bb into rmc.bb (userspace app) and >> > > rmc-efi.bb (efi library) and modify the compiler flags for each recipe. >> > > I will send a patch that does this. > > This patch should fix the x32 builds. > > https://lists.yoctoproject.org/pipermail/meta-intel/2017-July/004818.html >
you could use TUNE_CCARGS_remove = "xyz" instead of anonymous python > --Todor > >> > > >> > >> all: librmcefi >> > >> >> > >> $(RMC_LIB_OBJ): %.efi.o: %.c >> > > >> > > >> > > -- >> > > _______________________________________________ >> > > yocto mailing list >> > > yocto@yoctoproject.org >> > > https://lists.yoctoproject.org/listinfo/yocto >> >> > -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
