> -----Original Message----- > From: Joe MacDonald [mailto:joe_macdon...@mentor.com] > Sent: Tuesday, May 02, 2017 21:14 > To: Huang, Jie (Jackie) > Cc: yocto@yoctoproject.org > Subject: Re: [yocto] [meta-selinux][PATCH] systemd: no need to inherit enable- > selinux > > [[yocto] [meta-selinux][PATCH] systemd: no need to inherit enable-selinux] On > 17.02.22 (Wed 14:44) jackie.hu...@windriver.com wrote: > > > From: Jackie Huang <jackie.hu...@windriver.com> > > > > The selinux PACKAGECONFIG is properly handled in > > the recipe in oe-core, no need to inherit the > > enable-selinux bbclass. > > That might be true, but other than belt-and-suspenders, what's the > harm in this being in the recipe? I don't necessarily think it's an > invalid change but my quick count shows ~44 instances of 'inherit > enable-selinux' and 'inherit with-selinux' in meta-selinux, why's this > one significant?
That's because I have a patch to change the PACKAGECONFIG for selinux in oe-core to fix a dependency issue: -PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux" +PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux,initscripts-sushell" But it would be overrode by the one in enable-selinux.bbclass: $ grep PACKAGECONFIG enable-selinux.bbclass PACKAGECONFIG_append = " ${@target_selinux(d)}" PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux," So I need to remove the inherit here in meta-selinux. Thanks, Jackie > > -J. > > > > > Signed-off-by: Jackie Huang <jackie.hu...@windriver.com> > > --- > > recipes-core/systemd/systemd_%.bbappend | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/recipes-core/systemd/systemd_%.bbappend b/recipes- > core/systemd/systemd_%.bbappend > > index 8d9029b..f1bdaf8 100644 > > --- a/recipes-core/systemd/systemd_%.bbappend > > +++ b/recipes-core/systemd/systemd_%.bbappend > > @@ -1,2 +1 @@ > > inherit enable-audit > > -inherit enable-selinux > > -- > > 2.8.3 > > > -- > -Joe MacDonald. > :wq -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto