Hi.
Could you:
- Split this commit into 3 differents commits: one for firefly, one for
rk3288.inc and another one for the recipe
- Just call the recipe u-boot-rockchip, even if that's next we don't care.
That's your version of uboot based on mainline and it's a release branch,
so "next" is useless.
- I don't like COMPATIBLE_MACHINE=(rk3288)... only add supported boards
(that are parts of the meta layer)
Thanks!
Romain
2017-02-17 19:07 GMT+01:00 Trevor Woerner <twoer...@gmail.com>:
> From: Jacob Chen <jacob-c...@iotwrt.com>
>
> Rockchip next-dev U-boot is the next generation of rockchip u-boot, will
> also
> be an upstream tracking branch At present, this branch is just a rebased
> upstream u-boot.
>
> Reviewed-by: Trevor Woerner <twoer...@gmail.com>
> Signed-off-by: Jacob Chen <jacob-c...@iotwrt.com>
> ---
> conf/machine/firefly-rk3288.conf | 1 +
> conf/machine/include/rk3288.inc | 8 +++++++-
> recipes-bsp/u-boot/u-boot-rockchip_next.bb | 18 ++++++++++++++++++
> 3 files changed, 26 insertions(+), 1 deletion(-)
> create mode 100644 recipes-bsp/u-boot/u-boot-rockchip_next.bb
>
> diff --git a/conf/machine/firefly-rk3288.conf
> b/conf/machine/firefly-rk3288.conf
> index 8fa005d..58d752b 100644
> --- a/conf/machine/firefly-rk3288.conf
> +++ b/conf/machine/firefly-rk3288.conf
> @@ -8,3 +8,4 @@
>
> include conf/machine/include/rk3288.inc
> KERNEL_DEVICETREE = "rk3288-firefly.dtb"
> +UBOOT_MACHINE = "firefly-rk3288_defconfig"
> diff --git a/conf/machine/include/rk3288.inc
> b/conf/machine/include/rk3288.inc
> index 86fc567..f067ad5 100644
> --- a/conf/machine/include/rk3288.inc
> +++ b/conf/machine/include/rk3288.inc
> @@ -1,9 +1,15 @@
> # Copyright (C) 2015 Romain Perier
> # Released under the MIT license (see COPYING.MIT for the terms)
>
> +SOC_FAMILY = "rk3288"
> +
> require conf/machine/include/tune-cortexa17.inc
> +require conf/machine/include/soc-family.inc
>
> PREFERRED_PROVIDER_virtual/kernel = "linux"
> -SERIAL_CONSOLES = "115200;ttyS2"
> KERNEL_IMAGETYPE = "zImage"
> KBUILD_DEFCONFIG = "multi_v7_defconfig"
> +
> +PREFERRED_PROVIDER_virtual/bootloader = "u-boot-rockchip"
> +SERIAL_CONSOLES = "115200;ttyS2"
> +SPL_BINARY = "u-boot-spl-dtb.bin"
> diff --git a/recipes-bsp/u-boot/u-boot-rockchip_next.bb
> b/recipes-bsp/u-boot/u-boot-rockchip_next.bb
> new file mode 100644
> index 0000000..845f9da
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-rockchip_next.bb
> @@ -0,0 +1,18 @@
> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +require recipes-bsp/u-boot/u-boot.inc
> +
> +DESCRIPTION = "Rockchip next-dev U-Boot"
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://Licenses/README;md5=
> a2c678cfd4a4d97135585cad908541c6"
> +COMPATIBLE_MACHINE = "(rk3288)"
> +
> +SRC_URI = "git://github.com/rockchip-linux/u-boot.git;branch=release;"
> +SRCREV = "${AUTOREV}"
> +S = "${WORKDIR}/git"
> +
> +do_deploy_prepend () {
> + # copy to default search path
> + cp ${B}/spl/${SPL_BINARY} ${B}/
> +}
> --
> 2.11.0.258.ge05806d
>
>
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
