Hi all,

1. Add more details to your commits
2. As I said in a previous patch, I don't like this... rk-linux.inc , the
name of the file is not clear at all... and I don't like its content for
now.
3. There is really a small differences between a kernel mainline and your
kernel rk3288 nowadays... Do you have a working VPU in your kernel ?
perhaps that it might be interesting for this... (if I remember, it's not
supported in upstream)


Thanks,
Romain

2017-01-19 15:40 GMT+01:00 Eddie Cai <eddie.cai.li...@gmail.com>:

> Hi
>
> 2017-01-19 18:09 GMT+08:00 Jacob Chen <jacob-c...@iotwrt.com>:
> > This is the kernel vendor that supports all hw components for this board,
> > so we use it by default.
> The title and commit message didn't match the your content. Linux
> rockchip should refer to http://github.com/linux-rockchip.
> firefly-rk3288.conf already using http://github.com/linux-rockchip
> >
> > Signed-off-by: Jacob Chen <jacob-c...@iotwrt.com>
> > ---
> >  conf/machine/firefly-rk3288.conf | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/conf/machine/firefly-rk3288.conf
> b/conf/machine/firefly-rk3288.conf
> > index 8fa005d..47e63e1 100644
> > --- a/conf/machine/firefly-rk3288.conf
> > +++ b/conf/machine/firefly-rk3288.conf
> > @@ -7,4 +7,8 @@
> >  #http://www.t-firefly.com/en/
> >
> >  include conf/machine/include/rk3288.inc
> > +include conf/machine/include/rk-linux.inc
> > +
> >  KERNEL_DEVICETREE = "rk3288-firefly.dtb"
> > +
> > +UBOOT_MACHINE = "firefly-rk3288_defconfig"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > yocto mailing list
> > yocto@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/yocto
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
-- 
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Reply via email to