On Fri, 2016-12-02 at 14:29 -0600, Jose Lamego wrote:
> Patch Series created without a cover letter are named using a
> non-descriptive generic string.
>
> This change names the series using either the first 30 characters in
> patch #1 plus the remaining patches number, or the patch name for
> one-patch (1/1) series.
>
> [YOCTO #10625]
>
> Signed-off-by: Jose Lamego <jose.a.lam...@linux.intel.com>
> ---
> patchwork/models.py | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
When you send different versions of your patches, can you include a
revision history? Otherwise, it's hard to see what changes between the
different iterations.
git notes can be used for that for single-commit changes. See "git
format-patch --notes" and "git notes".
> diff --git a/patchwork/models.py b/patchwork/models.py
> index 3f531e6..1521641 100644
> --- a/patchwork/models.py
> +++ b/patchwork/models.py
> @@ -1042,6 +1042,19 @@ def _series_supersede_previous_patches(series):
> def _on_revision_complete(sender, revision, **kwargs):
> series = revision.series
>
> + # Now we know how many patches are in the revision,
> + # so we can update the name for series without a cover letter
> + if series.name == SERIES_DEFAULT_NAME:
> + name = series.latest_revision().ordered_patches()[0].name
> + n = re.compile(r'(\[\d+\/\d+\]\s?)')
> + name = n.sub('', name)
> + c = len(series.latest_revision().ordered_patches())
> + # For one-patch series (1/1) without cover letter
> + if c == 1:
> + series.name = name
> + elif c > 1:
> + series.name = "\"%s...\" and %s more" % (name[:30], c-1)
> +
> # update series.last_revision
> series.last_revision = series.latest_revision()
> series.save()
Looks reasonable to me, but I don't really know the code. Were you
testing this and noticed cases with c == 0, i.e. cases where the last
series,name change didn't make sense?
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
