Hi Humberto, I acked the patch only a few comments, you forget to sign your patch, please do with git commit -s.
Only for be clear this patch will support the next oe-selftest cmdline
also the old one so it could be integrated without the integration of
the oe-selttest new cmdline patch.
Cheers,
alimon
On 09/01/2016 01:56 PM, Humberto Ibarra wrote:
> oe-selftest is changing syntax with YOCTO #8938. This patch checks the
> correct syntax version and uses the right command to avoid breaking
> oe-seltest autobuilder. Should be integrated together with the syntax
> changing patch.
Acked-by: Aníbal Limón <anibal.li...@linux.intel.com>
>
> [YOCTO #8938]
> ---
> .../autobuilder/buildsteps/RunOeSelftest.py | 16
> ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git
> a/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
> b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
> index 809bcc3..ce0c0f6 100644
> --- a/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
> +++ b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
> @@ -34,9 +34,21 @@ class RunOeSelftest(ShellCommand):
> self.command += "netstat -an | grep -q 5901 ;"
> self.command += "if [ $? -ne 0 ]; then echo 'Starting a VNC server
> on :1'; vncserver :1; else echo 'Will use a VNC server already running on
> :1'; fi;"
> if self.tests == None:
> - self.command += "if [ -d ../meta-selftest ]; then export
> DISPLAY=:1; oe-selftest --run-all-tests; else echo 'Skipping step - no
> meta-selftest layer here'; fi"
> + oe_selftest_cmd = ('run', '--run-all-tests')
> else:
> - self.command += "if [ -d ../meta-selftest ]; then export
> DISPLAY=:1; oe-selftest " + self.tests + "; else echo 'Skipping step - no
> meta-selftest layer here'; fi"
> + oe_selftest_cmd = ("run --tests %s" % self.tests, "--run-tests
> %s" % self.tests)
> + self.command += """ \
> +if [ -d ../meta-selftest ]; then \
> + export DISPLAY=:1; \
> + VERSION=$(oe-selftest --version 2> /dev/null | cut -d' ' -f2); \
> + if [ \"$VERSION\" == '2.0' ]; then \
> + oe-selftest %s; \
> + else \
> + oe-selftest %s; \
> + fi; \
> +else \
> + echo 'Skipping step - no meta-selftest layer here';
> +fi""" % oe_selftest_cmd
> ShellCommand.start(self)
>
> def _createOESelftestErrorReport(self, log):
>
signature.asc
Description: OpenPGP digital signature
-- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
