On Tue, 2016-06-21 at 18:07 -0500, Aníbal Limón wrote: > This v2 adds support for generate also oe-selftest reports this is > almost > the previous version with changes requested in review [1], the next > patches > starts from patch, > > autobuilder/lib/{ABtools,builsteps}.py: Create > save_error_report func
A few comments. - Please rebase the last two commits. They can be merged into prior commits. Example: 0eb495d93eefa9ead8f4b1242f251f1a2288db68 should be squashed into 83b6707622128436b4ece9d4c2a89311b000c209 We shouldn't need rename commits for a pull request that created the original thing we're renaming. - Please fix the title for 83b6707622128436b4ece9d4c2a89311b000c209 's/buiidsets/buildsets/' -b -- Beth 'pidge' Flanagan <pi...@toganlabs.com> toganlabs.com > > Also the changes could be reviewed at [2]. > > [1] https://lists.yoctoproject.org/pipermail/yocto/2016-June/030515.h > tml > [2] http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/log/? > h=contrib/alimon/devel > > Aníbal Limón (15): > lib/buildsteps.py: Add BitbakeShellCommand class > lib/buildsteps.py: Add BitbakeLogLineObserver for > BitbakeShellCommands. > lib/buildsteps: BitbakeShellCommand add support for create error > reports > lib/ABTools: Add functions for get errordir path in controller and > worker > buildbot: Add support for DirectoryDownload transfer step > autobuilder/buildsteps: Add DownloadBitbakeErrorReports step > buiidsets: Add DownloadBitbakeErrorReport step > lib/buildsteps.py: BitbakeShellCommand add support for error_type > autobuilder/lib/buildsteps.py: BitbakeShellCommand update error > report > types. > autobuilder/lib/{ABtools,builsteps}.py: Create save_error_report > func > autobuilder/lib/ABTools.py: Add get_lsb_distro function > buildsteps/RunOeSelftest.py: Add support for create/save error > reports > nightly-oe-selftest.conf: Add steps for Download and Send error > report. > autobuilder/buildsteps: Rename DownloadBitbakeErrorReports to > DownloadErrorReports > buildset-config: Update references from DownloadBitbakeErrorReports > to > DownloadErrorReports > > buildset-config.controller/build-appliance.conf | 1 + > buildset-config.controller/buildtools.conf | 1 + > buildset-config.controller/nightly-arm-lsb.conf | 1 + > buildset-config.controller/nightly-arm.conf | 1 + > buildset-config.controller/nightly-arm64.conf | 1 + > .../nightly-deb-non-deb.conf | 1 + > buildset-config.controller/nightly-deb.conf | 1 + > buildset-config.controller/nightly-ipk.conf | 1 + > buildset-config.controller/nightly-mips-lsb.conf | 1 + > buildset-config.controller/nightly-mips.conf | 1 + > buildset-config.controller/nightly-mips64.conf | 1 + > buildset-config.controller/nightly-multilib.conf | 1 + > buildset-config.controller/nightly-musl.conf | 1 + > buildset-config.controller/nightly-no-x11.conf | 1 + > buildset-config.controller/nightly-non-gpl3.conf | 1 + > .../nightly-oe-selftest.conf | 5 +- > buildset-config.controller/nightly-oecore.conf | 1 + > buildset-config.controller/nightly-ppc-lsb.conf | 1 + > buildset-config.controller/nightly-ppc.conf | 1 + > buildset-config.controller/nightly-qa-extras.conf | 1 + > .../nightly-qa-logrotate.conf | 1 + > buildset-config.controller/nightly-qa-pam.conf | 1 + > .../nightly-qa-skeleton.conf | 1 + > buildset-config.controller/nightly-qa-systemd.conf | 1 + > .../nightly-qa-targetbuilds.conf | 1 + > .../nightly-rpm-non-rpm.conf | 1 + > buildset-config.controller/nightly-rpm.conf | 1 + > buildset-config.controller/nightly-uclibc.conf | 1 + > buildset-config.controller/nightly-world-lsb.conf | 1 + > buildset-config.controller/nightly-world.conf | 1 + > buildset-config.controller/nightly-x32.conf | 1 + > buildset-config.controller/nightly-x86-64-lsb.conf | 1 + > buildset-config.controller/nightly-x86-64.conf | 1 + > buildset-config.controller/nightly-x86-lsb.conf | 1 + > buildset-config.controller/nightly-x86.conf | 1 + > buildset-config.controller/nightly.conf | 1 + > buildset-config.controller/poky-tiny.conf | 1 + > buildset-config.examples/awesomefirmware.conf | 1 + > buildset-config.freescale/nightly-fsl-arm-lsb.conf | 1 + > buildset-config.freescale/nightly-fsl-arm.conf | 1 + > buildset-config.freescale/nightly-fsl-ppc-lsb.conf | 1 + > buildset-config.freescale/nightly-fsl-ppc.conf | 1 + > buildset-config.iot-devkit/iot-devkit.conf | 1 + > buildset-config.kernel/kernel-arm-lsb.conf | 1 + > buildset-config.kernel/kernel-arm.conf | 1 + > buildset-config.kernel/kernel-arm64.conf | 1 + > buildset-config.kernel/kernel-mips-lsb.conf | 1 + > buildset-config.kernel/kernel-mips.conf | 1 + > buildset-config.kernel/kernel-ppc-lsb.conf | 1 + > buildset-config.kernel/kernel-ppc.conf | 1 + > buildset-config.kernel/kernel-x86-64-lsb.conf | 1 + > buildset-config.kernel/kernel-x86-64.conf | 1 + > buildset-config.kernel/kernel-x86-lsb.conf | 1 + > buildset-config.kernel/kernel-x86.conf | 1 + > buildset-config.kernel/nightly-kernel.conf | 1 + > buildset-config.tizen/nightly-tizen-ivi.conf | 1 + > buildset-config.tizen/nightly-tizen.conf | 1 + > buildset-config.tizen/nightly.conf | 1 + > .../autobuilder/buildsteps/BuildImages.py | 7 +- > .../autobuilder/buildsteps/BuildToolchainImages.py | 7 +- > .../autobuilder/buildsteps/DownloadErrorReports.py | 42 +++++++++ > .../autobuilder/buildsteps/GetBitbakeVersion.py | 6 +- > .../autobuilder/buildsteps/RunESDKSanityTests.py | 6 +- > .../autobuilder/buildsteps/RunOeSelftest.py | 46 +++++++++ > .../autobuilder/buildsteps/RunSDKSanityTests.py | 6 +- > .../autobuilder/buildsteps/RunSanityTests.py | 6 +- > .../autobuilder/buildsteps/SendErrorReport.py | 16 ++-- > .../site-packages/autobuilder/lib/ABTools.py | 59 > ++++++++++++ > .../site-packages/autobuilder/lib/buildsteps.py | 104 > +++++++++++++++++++++ > .../buildbot/steps/transfer.py | 86 > ++++++++++++++++- > .../buildslave/commands/registry.py | 1 + > .../buildslave/commands/transfer.py | 79 > ++++++++++++++++ > 72 files changed, 509 insertions(+), 24 deletions(-) > create mode 100644 lib/python2.7/site- > packages/autobuilder/buildsteps/DownloadErrorReports.py > -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto