Hi Andrei, Khem, That's what I implemented in the upcoming v2 - except for the python checking function part. One thing, shall I call the variable CMA_SIZE, or VC4_CMA_SIZE? I know CMA is kind of common, but we're using this only to trigger a parameter to the v4c overlay. Any opinion? (in the current implementation, I went with CMA_SIZE, but I have doubts...)
Herve -----Original Message----- From: yocto-boun...@yoctoproject.org [mailto:yocto-boun...@yoctoproject.org] On Behalf Of Andrei Gherzan Sent: vendredi 20 mai 2016 12:40 To: Khem Raj <raj.k...@gmail.com> Cc: Yocto Project <yocto@yoctoproject.org> Subject: ***SPAM*** Re: [yocto] [meta-raspberrypi][PATCH 5/8] Support for vc4 graphics driver: upgrade 4.4 kernel to 4.4.10 On Thu, May 19, 2016 at 09:02:04AM -0700, Khem Raj wrote: > On Thu, May 19, 2016 at 8:11 AM, Andrei Gherzan <and...@gherzan.ro> wrote: > > On Wed, May 18, 2016 at 11:46:39PM +0200, Andreas Müller wrote: > >> On Wed, May 18, 2016 at 7:32 PM, Herve Jourdain <herve.jourd...@neuf.fr> wrote: > >> > One thing I didn't make configurable, but that maybe could be, is the parameter passed to the overlay. > >> > I selected cma-256, based on experience from other people, and because my configuration is RPI2/3 with 1G of memory. > >> > I realize it might not work well with RPI0/1, which have less memory available... > >> > So even if I believe cma-256 is a good default value, it might be made selectable by the user, if we want to consider vc4 on RPI0/1. > >> I played around with vc4 to but did not manage to get it work for > >> an elder version 4.1 of kernel. > >> > >> I did in rpi-config: > >> > >> CMA_SIZE = "cma-256" > >> CMA_SIZE_raspberrypi = "cma-64" > > > > > > I sent reply about this too. This is definitely one solution would I > > would rather have a CMA_SIZE default value and a python function to > > check its match with board variant. Cause in this way a user might > > be able to use cma-96 on rapsberrypi. > > > >> CMA_SIZE_raspberrypi0 = "cma-128" > > > setting CMA_SIZE should be moved into machine.conf file IMO > That's actually a good idea. I would say to have it in machine as a default value for that specific machine. And then be able to overwrite it as user needs. Optionally have a python function to check that what user requested makes sense for the selected board. -- Andrei Gherzan -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
