Hi Philip,
On 04/13/2016 09:42 PM, Philip Balister wrote:
>> +
>> > +Contributing
>> > +============
>> > +To contribute to this layer you should submit the patches for review to
>> > the
>> > +mailing list (yocto@yoctoproject.org).
>> > +
>> > +Please refer to
>> > + http://openembedded.org/wiki/Commit_Patch_Message_Guidelines
>> > +for some useful guidelines to be followed when submitting patches.
>> > +
>> > +Mailing list:
>> > + https://lists.yoctoproject.org/listinfo/yocto
>> > +
>> > +When creating patches, please use something like:
>> > + git format-patch -M -s --subject-prefix='psplash][PATCH' origin
>> > +
>> > +When sending patches, please use something like:
>> > + git send-email --to yocto@yoctoproject.org <generated patch>
>> >
> I cut and paste this line from the meta-oe README for sending patches,
> it is a bit simpler than the two step process:
>
> https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/README#L9
The line we are talking about is:
git send-email -M -1 --to openembedded-de...@lists.openembedded.org
--subject-prefix=meta-oe][PATCH
isn't it?
You're right, for one patch this line is simpler/faster. But basically I
like to create the patches first (and be able to review them) and send
them afterwards in a separate step.
Nonetheless if you like to add the "direct" send-email line I would at
least suggest to:
a) use "origin" as rev instead of "-1"
b) add "--annotate"
regards,
Richard
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
