> -----Original Message----- > From: linux-yocto-boun...@yoctoproject.org [mailto:linux-yocto- > boun...@yoctoproject.org] On Behalf Of Tom Zanussi > Sent: Friday, March 01, 2013 9:19 PM > To: Development list for the linux-yocto*.git Linux kernel repositories > Subject: Re: [linux-yocto] [PATCH 2/2] new feature for I/OAT DMA driver > > On Fri, 2013-03-01 at 17:05 -0800, nitin.a.kam...@intel.com wrote: > > From: Nitin A Kamble <nitin.a.kam...@intel.com> > > > > This commit implements a new ioatdma feature by providing a config > > fragment to enable Crystal Forest DMA/DCA (ioatdma) driver configuration > for BSP kernels. > > > > I'm just wondering if there's any overlap or conflict with the existing dca > feature - it seems that they at least have the CONFIG_INTEL_IOATDMA > option in common, so wondering whether the existing dca feature could > either use the ioatdma feature, or whether this new stuff could be using the > dca feature instead. I'm not too familiar with it, so can't say off the top > of my > head, just pointing it out in case you missed it... > > features/dca/dca.cfg: > > CONFIG_INTEL_IOATDMA=m > > and features/dca/dca.scc: > > define KFEATURE_DESCRIPTION "Enable DCA for IOATDMA capable devices" > define KFEATURE_COMPATIBILITY board > > kconf hardware dca.cfg > > include cfg/dmaengine.scc
Hi Tom, Good you found this overlap. This is the same feature with a different name. I will update my pull request accordingly. Nitin > > > > Signed-off-by: Nitin A Kamble <nitin.a.kam...@intel.com> > > --- > > meta/cfg/kernel-cache/features/ioatdma/ioatdma.cfg | 1 + > > meta/cfg/kernel-cache/features/ioatdma/ioatdma.scc | 1 + > > 2 files changed, 2 insertions(+), 0 deletions(-) create mode 100644 > > meta/cfg/kernel-cache/features/ioatdma/ioatdma.cfg > > create mode 100644 meta/cfg/kernel- > cache/features/ioatdma/ioatdma.scc > > > > diff --git a/meta/cfg/kernel-cache/features/ioatdma/ioatdma.cfg > > b/meta/cfg/kernel-cache/features/ioatdma/ioatdma.cfg > > new file mode 100644 > > index 0000000..b62aab2 > > --- /dev/null > > +++ b/meta/cfg/kernel-cache/features/ioatdma/ioatdma.cfg > > @@ -0,0 +1 @@ > > +CONFIG_INTEL_IOATDMA=y > > diff --git a/meta/cfg/kernel-cache/features/ioatdma/ioatdma.scc > > b/meta/cfg/kernel-cache/features/ioatdma/ioatdma.scc > > new file mode 100644 > > index 0000000..f1951a6 > > --- /dev/null > > +++ b/meta/cfg/kernel-cache/features/ioatdma/ioatdma.scc > > @@ -0,0 +1 @@ > > +kconf hardware ioatdma.cfg > > > _______________________________________________ > linux-yocto mailing list > linux-yo...@yoctoproject.org > https://lists.yoctoproject.org/listinfo/linux-yocto _______________________________________________ linux-yocto mailing list linux-yo...@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
