Hi Timo, The patch series looks much better. Here're few things we probably need to refine or explore a little bit more: 1. when I remove a profile, I'll get the following warning "Do you really want to the remove the target profile "profile-ide"?Projects using this target profile will be reconfigured to use the standard profile". But the reality is the project that is configured using the deleted profile won't be affected at all. You can go to the project->properties->Yocto Project Setting to check. So the message really should be: The standard profile will be used for Yocto Project ADT preference.
2. As to the "Save as.." button style consistency concern, yeah I can see it's a little bit unconventional. But my issue with new button is it gives the impression a separate wizard will show up to guide through the creation instead of just using the content on the page. Probably an "Add" button is less confusing and I've seen it's used on some pages and put it up besides the combobox? 3. The whole profile idea is applicable to per project ADT setting as well. By default it inherits what is set for the whole ADT plug-in in the preference window. But it can be something different aka. A different profile. Any plan to extend the capability here? Any further thoughts? Thanks, Jessica -----Original Message----- From: yocto-boun...@yoctoproject.org [mailto:yocto-boun...@yoctoproject.org] On Behalf Of Timo Mueller Sent: Sunday, February 03, 2013 11:36 PM To: yocto@yoctoproject.org Cc: Timo Mueller Subject: [yocto] [RFC v3 00/18][eclipse-poky] Storing yocto settings as target profiles From: Timo Mueller <timo.muel...@bmw-carit.de> Hi, thanks for the feedback, I did some changes to the patch series accordingly. First of all I've fixed the issues with the patches (duplicate method, missing fix for NewYoctoCProjectTemplate.java). I also changed the functionality of the "new" button according to Jessica's feedback. The logic is changed to a "Save as ..." approach. If the button is clicked the current values of the form are checked. If these are valid, the user can enter a name to store them as a new profile. The last patch moves the "Save as ..." button to the bottom of the preference page alongside with the "perform defaults" and the "apply" button. I created this patch as a proof of concept because I thought it would be a good idea to move it. I used the contributeButtons hook of the preference page to achieve this, but this only allows adding the "Save as ..." button left to the "perform defaults" button. So the order of the buttons is a bit confusing. I further checked several other preference pages of eclipse and it seems like none of them is using this hook to add new buttons. Instead all have a new button next to the comboboxes (e.g. Formatter for CDT and JDT). So I would plead against moving it to the bottom to have a more consistent and less confusing ui. >From the original cover letter: <snip> currently the yocto settings can be changed globally through eclipse's preferences or locally in the project properties. But the standard configuration stored in the global preferences sometimes changes, e.g. if a new version of the toolchain or the sysroot is released. If you change the global settings to the updated toolchain or sysroot your old working configuration is gone. If you want to reuse this configuration at a later point in time you have to (remember and) re-enter everthing. This patch set introduces the possiblity to store a configuration under a unique name, a so called target profile, and be able to select the default target profile that is used for new projects. Building upon this change the target profiles could later also be used in the project settings and be able to quickly build and debug your software for different hard- and software combinations. </snip> Best regards, Timo Atanas Gegov (4): plugins/sdk.ide: Extract labels to private members plugins/sdk.ide: Add method to enable and disable form plugins/sdk.ide: Set value of target array on input change plugins/sdk.ide: Create UI element for managing target profiles. Timo Mueller (14): plugins/sdk.ide: Removed unused message plugins/sdk.ide: Changed method signature to be more consistent plugins/sdk.ide: Modified preferences storage to support profiles. plugins/sdk.ide: Set profile on selection change plugins/sdk.ide: Add method to allow storing the current settings plugins/sdk.ide: Add UI method to create a new profile plugins/sdk.ide: Add UI method to delete a profile plugins/sdk.ide: Add UI method to rename a profile plugins/sdk.ide: Add method to change values of the preference page plugins/sdk.ide: Add method to rename a profile and its preference store plugins/sdk.ide: Add method to delete a profile plugins/sdk.ide: Use profiles for the preference page plugins/sdk.ide: Added profile UI to the preference page plugins/sdk.ide: Moved save as button to bottom of preference page .../src/org/yocto/sdk/ide/YoctoProfileElement.java | 104 ++++++++++ .../src/org/yocto/sdk/ide/YoctoProfileSetting.java | 211 +++++++++++++++++++++ .../org/yocto/sdk/ide/YoctoSDKMessages.properties | 19 +- .../src/org/yocto/sdk/ide/YoctoSDKPlugin.java | 9 + .../org/yocto/sdk/ide/YoctoSDKProjectNature.java | 10 +- .../src/org/yocto/sdk/ide/YoctoSDKUtils.java | 62 ++++-- .../src/org/yocto/sdk/ide/YoctoUISetting.java | 60 +++++- .../sdk/ide/preferences/PreferenceConstants.java | 5 + .../sdk/ide/preferences/PreferenceInitializer.java | 22 ++- .../ide/preferences/ProfileNameInputValidator.java | 63 ++++++ .../ide/preferences/YoctoSDKPreferencePage.java | 133 ++++++++++--- .../preferences/YoctoSDKProjectPropertyPage.java | 6 +- .../sdk/ide/wizard/NewYoctoCProjectTemplate.java | 7 +- 13 files changed, 646 insertions(+), 65 deletions(-) create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileElement.java create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/YoctoProfileSetting.java create mode 100644 plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/ProfileNameInputValidator.java -- 1.7.11.7 _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto
