On Thu, Jan 16, 2025 at 11:38 AM Bills, Jason M via lists.yoctoproject.org <jason.m.bills=linux.intel....@lists.yoctoproject.org> wrote: > > Hello, > > I recently pulled down this change that fixes an issue with EXTRA_IMAGECMD > support for squashfs-xz: > https://github.com/yoctoproject/poky/commit/70a857b8f3fd3e9b95b903e8313d0014a6ff8c96. >
Looking at this commit, it's using the 'local' keyword which is a bash extension and I wonder if that is right, since we support posix compliant shell syntax for executing shell tasks. what is your defautl shell, is it bash or dash ? > After that change, I now get a script error when running oe_mksquashfs(). > > This is the append I use: > EXTRA_IMAGECMD:squashfs-xz:append = "-processors 64 -b 262144 -Xdict-size > 100% -Xbcj arm" > > This is the error I get: > | DEBUG: Executing shell function do_image_squashfs_xz > | > /home/jmbills/upstream-sync/openbmc-openbmc/build/tmp/work/intel_ast2600-openbmc-linux-gnueabi/intel-platforms/1.0/temp/run.do_image_squashfs_xz.2945674: > 157: local: 64: bad variable name > | WARNING: exit code 2 from a shell command. > > The issue is fixed if I change this line: > local extra_imagecmd="$@" > to this: > local extra_imagecmd="$*" > > If that change looks correct, I can submit it as a patch, if that would be > helpful. > since "$*" Combines all arguments into a single string, separated by IFS compared to "$@" which keeps individual ariguments, it may result in same behaviour since we are not looping over these argument etc. what happens if you use single quotes around $@ > Thanks for your help, > -Jason > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#64570): https://lists.yoctoproject.org/g/yocto/message/64570 Mute This Topic: https://lists.yoctoproject.org/mt/110653777/21656 Group Owner: yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
