On 13 Mar 2024, at 16:44, Alexander Kanavin via lists.yoctoproject.org
<alex.kanavin=gmail....@lists.yoctoproject.org> wrote:
>
> The idiomatic pattern is to reject conditional patches in code review,
>
> Seriously, not a good idea - try to find a way to apply the patch
> without conditions, and trigger the condition through a configuration
> option, or runtime check.
The rationale behind this is that changes to the recipe/sources may mean the
patch no longer applies correctly if the PACKAGECONFIG is enable/disabled, but
that combination wasn’t tested.
If you _must_ apply a patch when PACKAGECONFIG has as value, then use
${@bb.utils.contains(“PACKAGECONFIG”, …)}. There’s many examples of this
function in oe-core, but just three instances of it being used with
PACKAGECONFIG for the reasons above.
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#62760): https://lists.yoctoproject.org/g/yocto/message/62760
Mute This Topic: https://lists.yoctoproject.org/mt/104909451/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
