Hi Trevor,

Looks good to me,

Reviewed-by: Quentin Schulz <quentin.sch...@theobroma-systems.com>

Cheers,
Quentin

On 10/25/23 16:57, Trevor Woerner via lists.yoctoproject.org wrote:
Looking forward, rkbin should only be used by specific Rockchip platforms
for which TF-A support is not (yet?) available. If rkbin gets added by
accident without an override, add a bbfatal to let the user know an
override is required.

Signed-off-by: Trevor Woerner <twoer...@gmail.com>
---
  recipes-bsp/rkbin/rockchip-rkbin_git.bb | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb 
b/recipes-bsp/rkbin/rockchip-rkbin_git.bb
index f9e680d16cb9..a3ab34189041 100644
--- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb
+++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb
@@ -25,7 +25,7 @@ do_install() {
  PACKAGES = "${PN}"
  ALLOW_EMPTY:${PN} = "1"
-do_deploy() {
+do_deploy:rk3588s() {
        # Prebuilt TF-A
        install -m 644 ${S}/bin/rk35/rk3588_bl31_v*.elf 
${DEPLOYDIR}/bl31-rk3588.elf
        # Prebuilt OPTEE-OS
@@ -34,4 +34,8 @@ do_deploy() {
        install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2736MHz_v*.bin 
${DEPLOYDIR}/ddr-rk3588.bin
  }
+do_deploy() {
+       bbfatal "COMPATIBLE_MACHINE requires a corresponding do_deploy:<MACHINE>() 
override"
+}
+
  addtask deploy after do_install





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#61574): https://lists.yoctoproject.org/g/yocto/message/61574
Mute This Topic: https://lists.yoctoproject.org/mt/102179996/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to