On 9/26/23 11:13, Quentin Schulz via lists.yoctoproject.org wrote:
Hi Anthony,
On 9/26/23 10:25, Anthony Davies wrote:
Hi Quentin
Happy to contribute but not all that familiar with emailing patches,
sorry.
The Signed-off-by needs to be present in the commit log already, it is
not related to mailing list submission. It is added with git commit
--signoff (or git commit -s), c.f.
https://docs.yoctoproject.org/contributor-guide/submit-changes.html. You're not the first one to forget it (or not know about it), nor will you be the last one, so no worries :)
I lumped them together because if you modify the KERNEL_IMAGETYPE you
trigger the bug.
But... you're not modifying the KERNEL_IMAGETYPE, you're merely allow it
to be changed. So you're technically not introducing a bug. And if we
wanted to be pedantic, we could say that this bug can technically
already be triggered by changing the KERNEL_IMAGETYPE in the machine
configuration file (and not in local.conf).
If you want to make sure one cannot modify the KERNEL_IMAGETYPE and
break the build, then you can add the commit handling the devicetree
before the one allowing to override the image type.
I agree moving it out of the include file would be the best way to go
but if you dont have the directory in the KERNEL_DEVICETREE it will
fail to compile, quickly searching other layers are handling it
similar to how I have, probably just in a more robust way.
This means we really need to fix this in openembedded-core! We shouldn't
rely on all layers to fix it themselves if we can avoid it.
Could you please provide the error log, which version of OE-Core/poky
you're building so we know a bit where to look :) ?
Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#61122): https://lists.yoctoproject.org/g/yocto/message/61122
Mute This Topic: https://lists.yoctoproject.org/mt/101589776/21656
Group Owner: yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
