It's fine to have both, you just need to write a good commit message explaining the issue. Also you need to explain why you need file binaries from oe-core in the sdk/tarball, instead of relying on file the host system.
Alex On Tue, 4 Jul 2023 at 13:41, Oleksiy Obitotskyy via lists.yoctoproject.org <[email protected]> wrote: > > Hi Alexander. > > We already use temporary fix, like: > > > diff --git a/meta/recipes-devtools/file/file_5.44.bb > b/meta/recipes-devtools/file/file_5.44.bb > index 3090d346ed..3a23e7721d 100644 > --- a/meta/recipes-devtools/file/file_5.44.bb > +++ b/meta/recipes-devtools/file/file_5.44.bb > @@ -45,10 +45,8 @@ do_install:append:class-native() { > } > > do_install:append:class-nativesdk() { > - mkdir -p ${D}${SDKPATHNATIVE}/environment-setup.d > - cat <<- EOF > ${D}${SDKPATHNATIVE}/environment-setup.d/file.sh > - export MAGIC="$OECORE_NATIVE_SYSROOT${datadir}/misc/magic.mgc" > - EOF > + create_cmdline_wrapper ${D}/${bindir}/file \ > + --magic-file ${datadir}/misc/magic.mgc > } > > I would like to ask if it possible to have in upstream both MAGIC variable > exported and wrapper for file. > If another binaries use MAGIC it's ok, but if we have to use file in > sub-shell it must work too. > > Regards, > Oleksiy > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#60512): https://lists.yoctoproject.org/g/yocto/message/60512 Mute This Topic: https://lists.yoctoproject.org/mt/99626082/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
