Hi Yann, Thanks for your contribution! :-)
On Mon 2021-03-22 @ 02:42:12 PM, [email protected] wrote: > This supports both the 2GB and 4GB versions of the board. This is not > done with 2 different machine definitions since only u-boot has to > change between those two configurations, but with a NANOPIM4_HW variable > to set in local.conf. Traditionally in meta-rockchip this is done using two separate machine files with all the common things factored into a common include file. See tinker-board and tinker-board-s as well as all the rock-pi-4* definitions for examples. I would prefer if the same thing was done here. That way it shows up as distinct machines in the layer index (for example) and makes it easier for users to determine whether or not their specific board is supported. Otherwise the full list of supported boards ends up getting buried and people have to dig around in the config files to find support information. Would you have time to re-spin the commit to add 2 boards (or just add the one you can test)? I see there's also a nanopi-m4b, but I can't find a simple comparison between the various nanopi-m4's. If you do, please add an entry in the README file as well. Otherwise I can take a look later today. Best regards, Trevor
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#52791): https://lists.yoctoproject.org/g/yocto/message/52791 Mute This Topic: https://lists.yoctoproject.org/mt/81524395/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
