Looks good, I went ahead and merged it. Thanks!

On Fri, Jun 1, 2012 at 6:17 AM, Alexandr Voidex <voidex....@gmail.com> wrote:
> Thanks for response!
>
> I agree that Vty should be the default (I changed them locally just
> for me, but pushed them on GitHub by mistake), so I changed back them
> in yi.cabal in my request.
> I also tested this build on Windows (clean Windows 7 and Windows 8
> Release Preview). It's now possible to completely build Yi with
> ghc-7.4.1:
>
> 1. Install GTK+ from 
> http://ftp.gnome.org/pub/GNOME/binaries/win32/glade3/3.6/glade3-3.6.7-with-GTK+.exe
> in folder withour spaces (for example C:\Programs\Gtk+)
> 2. Download and extract into Gtk+ path (in example: C:\Program\Gtk+)
> these archives:
>  a. 
> http://ftp.gnome.org/pub/gnome/binaries/win32/dependencies/fontconfig_2.8.0-2_win32.zip
>  b. 
> http://ftp.gnome.org/pub/gnome/binaries/win32/dependencies/expat_2.0.1-1_win32.zip
>  c. 
> http://ftp.gnome.org/pub/gnome/binaries/win32/dependencies/freetype_2.4.4-1_win32.zip
> 3. cabal install alex
> 4. cabal install happy
> 5. cabal install gtk2hs-buildtools
> 6. add cabal bin directory to PATH (or copy alex & happy somewhere in
> PATH)
> 7. Patch file \lib\pkgconfig\pango.pc in Gtk+ path (in example: C:
> \Program\Gtk+\lib\pkgconfig\pango.pc) with:
>  - Cflags: -I${includedir}/pango-1.0
>  + Cflags: -I${includedir}/pango-1.0 -I${includedir}
> 8. cabal install yi -f-vty -fpango (should work after applying my
> patch, i think, now i'm using 'cabal install' in yi directory)
>
>
> On 16 май, 02:12, Jeff Wheeler <jeffwhee...@gmail.com> wrote:
>> Thanks for the patch!
>>
>> It mostly looks good, but I think we should probably keep the Gtk
>> frontend non-default, and the Vty frontend default. It's been a while
>> since I played with it, but I think I remember the Gtk frontend being
>> relatively buggy, and it requires a lot stuff to install.
>>
>> Jeff
>>
>> On Sun, May 13, 2012 at 9:01 PM, mvoidex
>> <reply+i-4556604-00be0f3afc2f2308c4b4d5ca55497cb8a6235c23-14...@reply.github.com>
>> wrote:
>>
>>
>>
>>
>>
>> > canonicalizePath etc. works incorrect on Windows, I've fixed that.
>> > Also, I've changed config directory to AppData/Roaming/yi 
>> > (getAppUserDataDirectory), because Windows doesn't like names started from 
>> > dot.
>>
>> > You can merge this Pull Request by running:
>>
>> >  git pullhttps://github.com/mvoidex/yimaster
>>
>> > Or you can view, comment on it, or merge it online at:
>>
>> >  https://github.com/yi-editor/yi/pull/18
>>
>> > -- Commit Summary --
>>
>> > * Fixed path processing on Windows (and settings path moved to AppData)
>>
>> > -- File Changes --
>>
>> > M yi/src/library/System/CanonicalizePath.hs (10)
>> > M yi/src/library/System/FriendlyPath.hs (2)
>> > M yi/src/library/Yi/Config/Default.hs (37)
>> > M yi/yi.cabal (8)
>>
>> > -- Patch Links --
>>
>> >  https://github.com/yi-editor/yi/pull/18.patch
>> >  https://github.com/yi-editor/yi/pull/18.diff
>>
>> > ---
>> > Reply to this email directly or view it on GitHub:
>> >https://github.com/yi-editor/yi/pull/18
>>
>> --
>> Jeff Wheeler
>>
>> Undergraduate, Electrical Engineering
>> University of Illinois at Urbana-Champaign
>
> --
> Yi development mailing list
> yi-devel@googlegroups.com
> http://groups.google.com/group/yi-devel



-- 
Jeff Wheeler

Undergraduate, Electrical Engineering
University of Illinois at Urbana-Champaign

-- 
Yi development mailing list
yi-devel@googlegroups.com
http://groups.google.com/group/yi-devel

Reply via email to