Hi,

This is very interesting. I'm excited to see layout support in the vty front-end.

---

I'm not convinced that adding activity groups to the hierarchy is a good idea. In my opinion, *all* window/view layout should be handled by a 'LayoutManager' object -- primarily for simplicity, but also because this maintains a clean separation between layout and "semantics" of the windows/views. (By "semantics" I mean everything non-layout-related; for example, the behaviour of 'nextWinE'.)

If you're after manual control of your layout, then I think it would be better to implement a 'ManualLayoutManager' object, and just send messages to it telling it when to split. I've put an (incomplete, but compilable) prototype up on my github repo:
https://github.com/reinerp/yi/tree/manual-layout-manager

As you can see, this adds a generic 'sendMessage' method to the 'LayoutManager' class, which I think is a good idea in any case.

Admittedly, this layout manager wouldn't actually provide everything your "activities" support, because it gives you an all-or-nothing approach: you either use an automatic layout manager, or you have to do your layout entirely manually. If you want more advanced features, it should be possible to build more advanced layout managers in the same vein.

I think the other reason to stick with the 'LayoutManager' system is that it minimises the changes to "core yi". That is, the 'ManualLayoutManager' object could actually be implemented in someone's config file, without needing to change any of yi itself.

----

Regarding strictness: sorry if you're already aware of this, but we had a small discussion on strictness and deepseq a few weeks ago:
https://groups.google.com/d/topic/yi-devel/3dBiglnS7ko/discussion

Because 'rnf' on lists requires traversing the entire list, it might be a better idea (for efficiency reasons) to bite the bullet and migrate to strict lists/pointedlists. Unfortunately, there is no element-strict version of Data.Sequence, as far as I know.

----

Cheers,
Reiner


On 08/06/11 04:18, Corey O'Connor wrote:
screenshot:
http://imgur.com/JExhx

-Corey O'Connor
coreyocon...@gmail.com
http://corebotllc.com/




On Tue, Jun 7, 2011 at 11:10 AM, Corey O'Connor<coreyocon...@gmail.com>  wrote:
Howdy!
I just finished a large patch that adds horizontal and vertical
splits.*  Only  the VTY UI supports the changes for now. Layout
managers are still supported.

The branch is the activity-dev branch of mine on github:
https://github.com/coreyoconnor/yi/tree/activity-dev

With the patch being here:
https://github.com/coreyoconnor/yi/commit/0bec48fba7ac5538bc1d33f3540b541ffa24eebe

Read the patch notes for some more details. A short getting started:
1. checkout activity-dev from my yi git repo.
2. configure to only build and use the VTY UI.
3. Install.
4. Using the vim keymap try: control-w-s ; control-w-v ; ":new ...."

* Plus a concept called "activities" which I'll expand on later.

-Corey O'Connor
coreyocon...@gmail.com
http://corebotllc.com/


--
Yi development mailing list
yi-devel@googlegroups.com
http://groups.google.com/group/yi-devel

Reply via email to