On 21/05/11 06:56, Jean-Philippe Bernardy wrote:
I have casually looked through the code and I saw nothing against it.
As for the technique, I have to say it's a clever trick :). I normally would
have opposition of principle against unsafePerformIO, but you could argue
that serializable dynamics should be supported natively by GHC anyway.
That said, I remember that some version of Yi played badly with
unsafePerformIO...
Did you check that dynamically executed code works? If so I see no
reason to delay application of the patch.
Yes, I tested it. There's a problem with subprocesses like GHCi, but
that's actually for a different reason. I've committed the patch. Thanks
for the comments.
Cheers,
Reiner
--
Yi development mailing list
yi-devel@googlegroups.com
http://groups.google.com/group/yi-devel
