Comment #6 on issue 296 by DexterPu: CJK characters garbled in minibuffer
http://code.google.com/p/yi-editor/issues/detail?id=296

Please ignore the patches in comment 4 and 5. I assumed Yi.Buffer.Misc.file  
is used
to access buffer identifier in all circumstances, but it is not the case.

This patch, on the other hand, keep the UTF8 encoding for buffer  
identifiers. The
conversion to ISO 10464 is done in Yi.Buffer.Misc.shortIdentString and
Yi.Buffer.Misc.identString (Yi.Buffer.Misc.miniIdentString does not use  
path string)


We got two different encodings for paths: UTF8 for path manipulation and ISO
10464 for display and user input.

The idea of this patch and my previous patches on issue 296 is to convert
user input path string into UTF8 and convert internal UTF8 path string to  
ISO
10464 in Yi.Buffer.Misc.shortIdentString and Yi.Buffer.Misc.identString

Whenever one wants to use user input as path, he needs to convert the user  
input
string by Misc.readPath. This patch and previous patches fix this in Dired  
mode.
For emacs keymap, findFile and findFileNewTab have been fixed,
but the counterparts in other keymaps are yet to be fixed

AFAIK, path string may be displayed in following situations:
1. in the modeline (assume either Yi.Buffer.Misc.shortIdentString or
Yi.Buffer.Misc.identString is used here)
2. in Dired buffer
3. in minibuffer
4. msgEditor or errorEditor

for 1, this patch embedded the conversion into those functions
for 2, the previous patchs and this patch fixed all occurrences of path  
string
for 3, mainly hint and auto complete functions in promptFile, procDiredOp,  
rename and
file deletions.
for 4, fixed those in Dired.hs

These fixes will not affect ascii only strings.

Attachments:
        issue-296_2_.dpatch  55.4 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Yi development mailing list
yi-devel@googlegroups.com
http://groups.google.com/group/yi-devel
-~----------~----~----~----~------~----~------~--~---

Reply via email to