Hi!
> Here is some reviews.
>
Thanks! It's great help in learning Haskell :)
> Unneeded parens (3x)
> Trailing white-spaces
Corrected in attached patch.
> Look at "darcs replace" it would have made the patch clearer.
>
Cool, I didn't know about it.
>> - ,(char 'D', withEditor . cut Exclusive . (Replicate $ Move
>> Line Forward))
>> + ,(char 'D', withEditor . cut Exclusive . ArbMove .
>> viMoveToNthEol)
>>
> I trust you on this.
>
It makes a difference in stuff like 3D (it should delete from cursor to
end of line and 2 next lines)
>> - char 'C' ?>> beginIns self $ cut Exclusive
>> viMoveToEol, -- alias of "c$"
>> + char 'C' ?>> beginIns self $ cut Exclusive
>> viMoveToEol, -- alias of "c$" FIXME
>>
> Why?
>
It doesn't honor count argument (eg. 3C). Comment fixed in patch
(problem not :-/ )
> OK OK OK OK
Cool ;-)
Cheers,
--
Krzysiek
--~--~---------~--~----~------------~-------~--~----~
Yi development mailing list
yi-devel@googlegroups.com
http://groups.google.com/group/yi-devel
-~----------~----~----~----~------~----~------~--~---
Wed Dec 3 16:55:12 CET 2008 Krzysztof Goj <[EMAIL PROTECTED]>
* Comments fix
- Esc leaves visual mode -- dropping comment
- Explain and extend a FIXME for S and C
Wed Dec 3 16:56:44 CET 2008 Krzysztof Goj <[EMAIL PROTECTED]>
* Unneeded parens.
Wed Dec 3 16:57:21 CET 2008 Krzysztof Goj <[EMAIL PROTECTED]>
* Trailing whitespace.
New patches:
[Comments fix
Krzysztof Goj <[EMAIL PROTECTED]>**20081203155512
- Esc leaves visual mode -- dropping comment
- Explain and extend a FIXME for S and C
] hunk ./Yi/Keymap/Vim.hs 43
--
-- What's missing?
--- ESC should leave from the visual mode
-- fancier :s// ==> missing /c, ...
-- '.'
-- @:
hunk ./Yi/Keymap/Vim.hs 682
char 'o' ?>> beginIns self $ moveToEol >> insertB '\n',
char 'O' ?>> beginIns self $ moveToSol >> insertB '\n' >>
lineUp,
char 'c' ?>> changeCmds,
- char 'C' ?>> beginIns self $ cut Exclusive viMoveToEol,
-- alias of "c$" FIXME
+
+ -- FIXME: those two should take int argument
+ char 'C' ?>> beginIns self $ cut Exclusive viMoveToEol,
-- alias of "c$"
char 'S' ?>> beginIns self $ withBuffer0 moveToSol >> cut
Exclusive viMoveToEol, -- non-linewise alias of "cc"
char 's' ?>> beginIns self $ cut Exclusive (CharMove
Forward), -- non-linewise alias of "cl"
char '/' ?>>! ex_mode "/",
[Unneeded parens.
Krzysztof Goj <[EMAIL PROTECTED]>**20081203155644] hunk ./Yi/Keymap/Vim.hs 109
-- | Replace mode is like insert, except it performs writes, not inserts
rep_mode :: VimMode
- rep_mode = write (setStatus ("-- REPLACE --", defaultStyle)) >> many
rep_char >> leave >> (write leftB)
+ rep_mode = write (setStatus ("-- REPLACE --", defaultStyle)) >> many
rep_char >> leave >> write leftB
-- | Reset the selection style to a character-wise mode 'SelectionStyle
Character'.
resetSelectStyle :: BufferM ()
hunk ./Yi/Keymap/Vim.hs 151
return $ Just $ read (c:cs)
viMoveToNthEol :: Int -> BufferM ()
- viMoveToNthEol n = (replicateM_ n $ moveB Line Forward)
+ viMoveToNthEol n = replicateM_ n $ moveB Line Forward
viMoveToEol :: ViMove
viMoveToEol = MaybeMove Line Forward
hunk ./Yi/Keymap/Vim.hs 1069
-- | Insert mode is either insertion actions, or the meta (\ESC) action
ins_mode :: ModeMap -> VimMode
-ins_mode self = write (setStatus ("-- INSERT --", defaultStyle)) >> many
(v_ins_char self <|> kwd_mode) >> leave >> (write leftB)
+ins_mode self = write (setStatus ("-- INSERT --", defaultStyle)) >> many
(v_ins_char self <|> kwd_mode) >> leave >> write leftB
beginIns :: (Show x, YiAction a x) => ModeMap -> a -> I Event Action ()
beginIns self a = write a >> ins_mode self
[Trailing whitespace.
Krzysztof Goj <[EMAIL PROTECTED]>**20081203155721] hunk ./Yi/Keymap/Vim.hs 124
write (setVisibleSelection True >> pointB >>= setSelectionMarkPointB)
core_vis_mode selStyle
write (clrStatus >> withBuffer0 (setVisibleSelection False) >>
withBuffer0 resetSelectStyle)
-
+
core_vis_mode :: SelectionStyle -> VimMode
core_vis_mode selStyle = do
write $ do withBuffer0 $ setDynamicB $ selStyle
Context:
[Behaviour at end of line (BIG PATCH)
Krzysztof Goj <[EMAIL PROTECTED]>**20081203031045
- Doesn't allow to go to EOL in normal mode
- Does allow it in other (visual, insert, replace) modes
- Corrected D, and '$' command
- cursor moves left after leaving insert and replace mode
]
[Corrected 'x' and 'X' behaviour
Krzysztof Goj <[EMAIL PROTECTED]>**20081203125741
Now 'x' and 'X' are aliases to dl and dh (as in Vim) -- they cannot delete
newline character.
]
[Ctrl+h in insert and replace mode; Ctrl+w in replace mode
Krzysztof Goj <[EMAIL PROTECTED]>**20081203012614]
[Ctrl+h in Ex mode
Krzysztof Goj <[EMAIL PROTECTED]>**20081203000017]
[Ctrl+p, Ctrl+n in Ex mode
Krzysztof Goj <[EMAIL PROTECTED]>**20081202235807]
[Vim visual mode: 's' is synonym to 'c'
Krzysztof Goj <[EMAIL PROTECTED]>**20081202233509]
[Vim: ctrl+u, ctrl+d scrolling
Krzysztof Goj <[EMAIL PROTECTED]>**20081202231544]
[Ctrl-t and Ctrl-d in insert mode (indentation)
Krzysztof Goj <[EMAIL PROTECTED]>**20081202223751]
[Fixed isMakefile: takeBaseName should be takeFileName. Otherwise makefile's
named like foo.mk would not be recognized.
[EMAIL PROTECTED]
[Issue 202: indentation and Vim commands
Krzysztof Goj <[EMAIL PROTECTED]>**20081202183446
Added indentation-awareness to cutRegion, pasteBefore and pasteAfter.
]
[Better percent move.
Krzysztof Goj <[EMAIL PROTECTED]>**20081202162105]
[replace all: more helpful message
[EMAIL PROTECTED]
[fix build
[EMAIL PROTECTED]
[Better word and WORD motions for Vim keymap.
Krzysztof Goj <[EMAIL PROTECTED]>**20081202132813]
[doc
[EMAIL PROTECTED]
[Yi/Users/Gwern.hs: +shorter binding for gotoLn
[EMAIL PROTECTED]
Ignore-this: 5defc56344c3e1c61bd602d192e06af3
I find the default Emacs binding of M-g g tedious; why not just M-g?
]
[doc
[EMAIL PROTECTED]
[make Accessor instance of Category
[EMAIL PROTECTED]
[use Control.Category
[EMAIL PROTECTED]
[Yi.Keymap.Emacs: +standard emacs M-; binding
[EMAIL PROTECTED]
Ignore-this: 5abf2d7154acfdcce44286f34ec238b9
]
[update to base>=4; replace all Control.Exception with Control.OldException
[EMAIL PROTECTED]
Ignore-this: 205b7c23a4ffcc16b8612d0b4edc9352
]
[better support for vivid colors
[EMAIL PROTECTED]
[Main.hs: minor indent
[EMAIL PROTECTED]
Ignore-this: b53fd55beb556c92b6bba9ee4a49cd61
]
[added C-w and C-u to ex mode
Aleksandar Dimitrov <[EMAIL PROTECTED]>**20081201103414]
['ZZ' closes window, not editor, 'ZQ' == ':q!'
Aleksandar Dimitrov <[EMAIL PROTECTED]>**20081201103311]
[bump version number
[EMAIL PROTECTED]
[TAG 0.5.2
[EMAIL PROTECTED]
Patch bundle hash:
1590e0f0e88e02f90c09f26804f619a811ca1418
