Reviewed: https://review.opendev.org/c/openstack/neutron/+/926497 Committed: https://opendev.org/openstack/neutron/commit/40657fab6302f4625e4c3d52481e1801080b649d Submitter: "Zuul (22348)" Branch: master
commit 40657fab6302f4625e4c3d52481e1801080b649d Author: Brian Haley <haleyb....@gmail.com> Date: Sat Aug 17 19:28:03 2024 -0400 Optionally configure IPv6 metadata address If there is a network without an IPv6 subnet, the dhcp-agent does not need to configure an IPv6 metadata address. There is the possibility this could cause a failure if one of the IPv4 subnets has a small mtu (<1280). Re-arranged code slightly to only loop through the subnets a single time doing multiple checks at once. Similarly, the OVN metadata agent should only configure IPv6 addresses if there is an IPv6 subnet present, and remove any IPv6 addresses if they are removed. It should also only listen in the IPv6 metadata address if IPv6 is enabled, same as the dhcp-agent does. Had to change a number of OVN metadata tests to account for cases where IPv6 is/is not enabled and IPv6 subnets are/are not present. Closes-bug: #2074207 Change-Id: Ib332c357bc1c330cd7c2645b9fbbf5bdbdeb899f ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/2074207 Title: DHCP agent makes endless attempts to configure a network with MTU < 1280 Status in neutron: Fix Released Bug description: I get endless attempts to configure the network in the neutron-dhcp- agent logs. Conditions - devstack setup with extra `force_metadata = true` config option. - DHCP enabled vxlan network with MTU=1000 $ openstack network create net1000 --mtu 1000 $ openstack subnet create sub1 --network net1000 --dhcp --subnet-range 10.20.30.0/24 Jul 26 09:38:35 devoct30 neutron-dhcp-agent[1690530]: INFO neutron.agent.dhcp.agent [None req-dfc13386-aaed-48e3-80b5-ebad6f324f3a None None] Synchronizing state Jul 26 09:38:35 devoct30 neutron-dhcp-agent[1690530]: INFO oslo_messaging._drivers.amqpdriver [None req-2caf8aeb-fbf0-457f-ac27-35d9aa75db90 None None] Expecting reply to msg 57ad6fa408c5444aa5b56be27020ccce in queue reply_081c0528a7b5431897eb5e8a5e4a7919 Jul 26 09:38:35 devoct30 neutron-dhcp-agent[1690530]: INFO oslo_messaging._drivers.amqpdriver [-] Received RPC response for msg 57ad6fa408c5444aa5b56be27020ccce Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: INFO neutron.agent.dhcp.agent [None req-2caf8aeb-fbf0-457f-ac27-35d9aa75db90 None None] All active networks have been fetched through RPC. Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: INFO neutron.agent.dhcp.agent [-] Starting network e5e3d4ff-f552-4864-aafc-5ed022616467 dhcp configuration Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent [-] Unable to enable dhcp for e5e3d4ff-f552-4864-aafc-5ed022616467.: neutron.privileged.agent.linux.ip_lib.InvalidArgument: Invalid parameter/value used on interface tapb8ae86a5-ca, namespace qdhcp-e5e3d4ff-f552-4864-aafc-5ed022616467. Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent Traceback (most recent call last): Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/dhcp/agent.py", line 265, in _call_driver Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent rv = getattr(driver, action)(**action_kwargs) Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/linux/dhcp.py", line 331, in enable Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent common_utils.wait_until_true(self._enable, timeout=300) Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/common/utils.py", line 739, in wait_until_true Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent while not predicate(): Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/linux/dhcp.py", line 343, in _enable Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent interface_name = self.device_manager.setup( Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/linux/dhcp.py", line 1890, in setup Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent self.driver.init_l3(interface_name, ip_cidrs, Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/linux/interface.py", line 152, in init_l3 Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent device.addr.add(ip_cidr) Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/linux/ip_lib.py", line 560, in add Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent add_ip_address(cidr, self.name, self._parent.namespace, scope, Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/opt/stack/neutron/neutron/agent/linux/ip_lib.py", line 853, in add_ip_address Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent privileged.add_ip_address( Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/usr/local/lib/python3.9/site-packages/oslo_privsep/priv_context.py", line 271, in _wrap Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent return self.channel.remote_call(name, args, kwargs, Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent File "/usr/local/lib/python3.9/site-packages/oslo_privsep/daemon.py", line 215, in remote_call Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent raise exc_type(*result[2]) Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent neutron.privileged.agent.linux.ip_lib.InvalidArgument: Invalid parameter/value used on interface tapb8ae86a5-ca, namespace qdhcp-e5e3d4ff-f552-4864-aafc-5ed022616467. Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: ERROR neutron.agent.dhcp.agent Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: INFO neutron.agent.dhcp.agent [-] Finished network e5e3d4ff-f552-4864-aafc-5ed022616467 dhcp configuration Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: INFO neutron.agent.dhcp.agent [None req-2caf8aeb-fbf0-457f-ac27-35d9aa75db90 None None] Synchronizing state complete Jul 26 09:38:36 devoct30 neutron-dhcp-agent[1690530]: INFO neutron.agent.dhcp.agent [None req-2caf8aeb-fbf0-457f-ac27-35d9aa75db90 None None] Synchronizing state To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/2074207/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp