Reviewed: https://review.opendev.org/c/openstack/neutron/+/935046 Committed: https://opendev.org/openstack/neutron/commit/0c29e730db2629c084de0c114a0d1e8e6939ac25 Submitter: "Zuul (22348)" Branch: master
commit 0c29e730db2629c084de0c114a0d1e8e6939ac25 Author: Rodolfo Alonso Hernandez <ralon...@redhat.com> Date: Wed Nov 13 22:12:17 2024 +0000 Catch when the process does not exist when killing it In ``ProcessManager.disable``, it could happen that the process to be stopped is no longer present in the system. In that case, catch this exception and dismiss it. If the goal of the ``disable`` method is to stop the process, it should not fail in the case of not being present anymore. Closes-Bug: #2088154 Change-Id: I5c6f7648d69e3a939445273f8d94241818538fc9 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/2088154 Title: ``ProcessManager.disable`` failing if the process doesn't exist Status in neutron: Fix Released Bug description: The method ``ProcessManager.disable`` sends a signal (HUP or KILL) to finish an existing process. In [1], before sending the signal, it is checked that the process exists. There is a very narrow possibility that between this check and the sending of the signal, the process has been terminated. It is needed to catch this exception and dismiss it. Logs: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a5a/periodic/opendev.org/openstack/neutron/master/neutron- functional-with-oslo-master/a5abf3a/testr_results.html Snippet: https://paste.opendev.org/show/b8M8TLhEXkhKxrr2pC7p/ [1]https://github.com/openstack/neutron/blob/081b2e6fc7f64ecebee7165755ecca0204c56aaf/neutron/agent/linux/external_process.py#L123 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/2088154/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp