Reviewed: https://review.opendev.org/c/openstack/neutron/+/926725 Committed: https://opendev.org/openstack/neutron/commit/a859760323a878ced58c2c01b6da8d0f803028be Submitter: "Zuul (22348)" Branch: master
commit a859760323a878ced58c2c01b6da8d0f803028be Author: Rodolfo Alonso Hernandez <ralon...@redhat.com> Date: Thu Aug 8 18:23:28 2024 +0000 Neutron quota engine checks the resource usage by default Now the Neutron quota engine always checks the current resource usage before updating the quota limits. Only when the CLI "--force" parameter is passed, this check is skipped. That aligns the Neutron quota engine behaviour with other projects. The Neutron quota commands now always check the resource limits. The CLI parameter "--check-limits" is no longer needed, as this is the default behaviour. Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/928770 Closes-Bug: #1953170 Change-Id: I2a9cd89cfe40ef635892cefeb61264272fe7bf16 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1953170 Title: [RFE] Unify quota engine API Status in neutron: Fix Released Bug description: DESCRIPTION ----------- In sake of simplicity, Neutron should adopt the same quota API behaviour as Nova and Cinder. Current behaviour when a new quota limit is set: 1) Neutron: $ openstack quota set --network 100 <project> # Quota is set WITHOUT checking the current network usage. $ openstack quota set --network 100 --check-limit <project> # Quota is set AFTER checking the current network usage. 2) Nova: (just the opposite) $ openstack quota set --ram 100 <project> # Quota is set AFTER checking the current network usage. $ openstack quota set --ram 100 --force <project> # Quota is set WITHOUT checking the current network usage. That means Neutron forces by default the quota update while in Nova you need to specify the "--force" parameter. The goal of this RFE is to plan a smooth migration to the Nova quota API behaviour: by default, always check the resource limit; if "-- force" is provided, no check will be done. STEPS ----- 1) Implement in OSC both "--force" and "--check-limit" parameters for "quota set" command. The "--force" parameter is already present. "--check-limit" will be merged in [1]. The functionality in Neutron quota system to check the resource usage is merged in Neutron [2]. This step can be considered as DONE. 2) Modify the quota engine to accept "--force" parameter. We'll discard it because this is the default behaviour. 3) Write a warning message in the logs. If no parameter is passed (force, check-limit), that means the user is using the "old" API. In this case, we'll inform in this message about the future change we'll make in the API (with references to this LP bug). 4) In 2 or 3 releases, change the behaviour in the Neutron quota engine: by default, we'll always check the resource limits. Remove the warning message. 5) Remove from OSC the parameter "--check-limit" (unnecessary now). 6) Remove from Neutron quota engine the "--check-limit" input parameter. [1]https://review.opendev.org/c/openstack/python-openstackclient/+/806016 [2]https://review.opendev.org/c/openstack/neutron/+/801470 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1953170/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp