Reviewed: https://review.opendev.org/729167 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=30d573d5abeb4a5251d08dc5384f5c0ff372eff8 Submitter: Zuul Branch: master
commit 30d573d5abeb4a5251d08dc5384f5c0ff372eff8 Author: Slawek Kaplonski <[email protected]> Date: Tue May 19 10:04:18 2020 +0200 Allow usage of legacy 3rd-party interface drivers In the patch [1] we changed definition of the abstract method "plug" in the LinuxInterfaceDriver class. That broke e.g. 3rd-party drivers which still don't accept this new parameter called "link_up" in the plug_new method. So this patch fixes this to make such legacy drivers to be still working with the new base interface driver class. This commit also marks such definition of the plug_new method as deprecated. Possibility of using it without accepting link_up parameter will be removed in the "W" release of the OpenStack. [1] https://review.opendev.org/#/c/707406/ Change-Id: Icd555987a1a57ca0b31fa7e4e830583d6c69c861 Closes-Bug: #1879307 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1879307 Title: Recent stable/rocky change breaks networking-calico's interface driver Status in neutron: Fix Released Bug description: This merge - https://opendev.org/openstack/neutron/commit/a6fb2faaa5d46656db9085ad6bcfc65ded807871 - to the Neutron stable/rocky branch on April 23rd, has broken my team's Neutron plugin, by requiring 3rd party LinuxInterfaceDriver subclasses to take a new 'link_up' argument in their 'plug_new' method. Here's the fix that I've now made: https://github.com/projectcalico /networking- calico/pull/21/commits/bfd54aa841abbba4c591126b0dba083b93c84536 However, this likely affects other out-of-tree plugins as well, and there is still the likelihood of breakage if someone is running Rocky with an affected-but-unfixed plugin, and uses the latest Rocky code. Apparently there will not be another Rocky patch release, so I wonder if it would be better to revert the incompatible change? To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1879307/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
