Reviewed: https://review.opendev.org/702642 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f9e0f8a976b82088ef095a69cd1fa892cddde3ba Submitter: Zuul Branch: master
commit f9e0f8a976b82088ef095a69cd1fa892cddde3ba Author: Rikimaru Honjo <[email protected]> Date: Wed Jan 15 10:48:14 2020 +0000 Allow to evacuate without specifying a target host When the evacuate is run without specifying a target host, horizon sets an empty string for target host. But the evacuate api doesn't allow an empty string. As a result, nova returns "HTTP 400 Bad request". So this patch sets None as the target host when it isn't specified. Change-Id: Ia865a6c02e206fa49efc3095e8d3488f5638d0e3 Closes-Bug: 1793694 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1793694 Title: [Queens] evacuate fails if target is not selected Status in OpenStack Dashboard (Horizon): Fix Released Bug description: It looks like the issue fixed in bug 1652494 has been reintroduced here: https://github.com/openstack/horizon/blob/stable/queens/openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py#L49:L53 When "target host" is set to "Select a target host", Nova API logs show: """ body: {"evacuate": {"host": "", "onSharedStorage": true}} Returning 400 to user: Invalid input for field/attribute host. Value: . u'' is too short """ When a target host is selected, Nova API logs show: """ body: {"evacuate": {"host": "target-hostnameXX", "onSharedStorage": false}} """ In the first case, the expectation is to have both host and onSharedStorage set to False. The latter was never enabled, but it looked so in the first test when it shouldn't. Horizon is running on Ubuntu Xenial, openstack-dashboard 3:13.0.1-0ubuntu1~cloud0 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1793694/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
