Reviewed: https://review.opendev.org/655712
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=091a910576d9b580678f1881fffa425ab4632f48
Submitter: Zuul
Branch: master
commit 091a910576d9b580678f1881fffa425ab4632f48
Author: Lee Yarwood <lyarw...@redhat.com>
Date: Thu Apr 25 15:34:41 2019 +0100
libvirt: Always disconnect volumes after libvirtError exceptions
Building on Ib440f4f2e484312af5f393722363846f6c95b760 we should always
attempt to disconnect volumes from the host when exceptions are thrown
while attempting to attach a volume to a domain. This was previously
done for generic exceptions but not for libvirtError exceptions.
Closes-Bug: #1826523
Change-Id: If21230869826c992e7d0398434b9a4b255940213
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1826523
Title:
libvirtError exceptions during volume attach leave volume connected to
host
Status in OpenStack Compute (nova):
Fix Released
Status in OpenStack Compute (nova) queens series:
Confirmed
Status in OpenStack Compute (nova) rocky series:
Confirmed
Status in OpenStack Compute (nova) stein series:
Confirmed
Bug description:
Description
===========
In addition to bug #1825882 where libvirtError exceptions are not
raised correctly when attaching volumes to domains the underlying
volumes are not disconnected from the host.
Steps to reproduce
==================
- virsh detach-disk <domain> vdb
- update nova & cinder DB as if volume is detached
- re-attach volume
Expected result
===============
Volume attach fails and the volume is disconnected from the host.
Actual result
=============
volume attach fails but remains connected to the host.
Environment
===========
1. Exact version of OpenStack you are running. See the following
list for all releases: http://docs.openstack.org/releases/
master to stable/queens
2. Which hypervisor did you use?
(For example: Libvirt + KVM, Libvirt + XEN, Hyper-V, PowerKVM, ...)
What's the version of that?
Libvirt + QEMU/KVM
2. Which storage type did you use?
(For example: Ceph, LVM, GPFS, ...)
What's the version of that?
N/A
3. Which networking type did you use?
(For example: nova-network, Neutron with OpenVSwitch, ...)
N/A
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1826523/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
