Public bug reported: When using add_item_link in a workflow action (like the workflow for allocating a floating ip to an instance), the modal throws an error and never returns to the original action.
The form view for the floating ip allocation action is returning the following: "["f5aae610-0bed-45d7-a5e5-1cae9f3a30a7", "172.24.4.42"]<!-- F07NtaYHLrZ0M7Du -->" Which then the modal.js code can't parse as json and just stalls: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.modals.js#L330 I'm not 100% sure what the hell "<!-- F07NtaYHLrZ0M7Du -->" is, or where it is coming from, but it's something I've only just now encountered in Devstack. I find it unlikely that Django itself does it, so it could be something like apache. The issue goes away when we set the content-type to text/plain. We can't set it to json because other parts of the modal.js parse it and then the code breaks in the same place but for different reasons... Basically, we aren't setting content-type, so it defaults to html: https://github.com/openstack/horizon/blob/master/horizon/forms/views.py#L195 ** Affects: horizon Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1824484 Title: workflow modal add_item_link is broken Status in OpenStack Dashboard (Horizon): New Bug description: When using add_item_link in a workflow action (like the workflow for allocating a floating ip to an instance), the modal throws an error and never returns to the original action. The form view for the floating ip allocation action is returning the following: "["f5aae610-0bed-45d7-a5e5-1cae9f3a30a7", "172.24.4.42"]<!-- F07NtaYHLrZ0M7Du -->" Which then the modal.js code can't parse as json and just stalls: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.modals.js#L330 I'm not 100% sure what the hell "<!-- F07NtaYHLrZ0M7Du -->" is, or where it is coming from, but it's something I've only just now encountered in Devstack. I find it unlikely that Django itself does it, so it could be something like apache. The issue goes away when we set the content-type to text/plain. We can't set it to json because other parts of the modal.js parse it and then the code breaks in the same place but for different reasons... Basically, we aren't setting content-type, so it defaults to html: https://github.com/openstack/horizon/blob/master/horizon/forms/views.py#L195 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1824484/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
