Reviewed: https://review.openstack.org/560907 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5179896e771c8c4789c605bad3e2ef188808e831 Submitter: Zuul Branch: master
commit 5179896e771c8c4789c605bad3e2ef188808e831 Author: Thomas Morin <[email protected]> Date: Thu Apr 12 15:07:20 2018 +0200 Allow sub-resources to have standard attributes Prior to this change a DB model with standard attributes could declare that it was mapping to an API resource, but not declare a mapping to a sub-resources (see bug 1763347). This change allows DB models with standard attributes to advertise that they map API *sub*-resources, and modifies the code that extends DB resources to support these specific declarations. Closes-Bug: 1763347 Needed-By: I77ce46c0f33e2a366076d51ce6586fb3008dc6b1 Change-Id: I7630aab5e4f38d0fba862adc2426d4a7ca04a679 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1763347 Title: internal: cannot apply standard attributes to sub-resources Status in neutron: Fix Released Bug description: The code for extending the resource map with the standard attributes for a resource declared in api_collections (e.g. [1]), does only work for plain resources, but not for sub-resources (it produces a {'resource': attribute_dict} dictionary, while a {'resource': {'parameters': attribute_dict}} would be required by the code at [2]. This makes it impossible to add standard attributes to sub-resources. [1] https://github.com/openstack/neutron/blob/a0e0e8b6686b847a4963a6aa6a3224b5768544e6/neutron/extensions/standardattrdescription.py#L51-L55 [2] https://github.com/openstack/neutron/blob/c0c40f8dbc22b7ec3886845a83f19e6ed46af264/neutron/api/extensions.py#L349-L355 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1763347/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
