Reviewed: https://review.openstack.org/500801 Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas-dashboard/commit/?id=e2d30b97cfb51fd46cb87cce6f6c779787f10fdd Submitter: Jenkins Branch: master
commit e2d30b97cfb51fd46cb87cce6f6c779787f10fdd Author: Akihiro Motoki <[email protected]> Date: Tue Sep 5 11:03:52 2017 +0000 v1 dashboard: Fix a bug that rule cannot be updated Previously firewall rules cannot be updated because uppercase protocol names are passed to neutron server but FWaaS v1 API accepts only lowercase protocol names. There is no reason to use uppercase values in the dashboard code except the labels. This commit converts uppercase values in protocol and action into lowercase values. Closes-Bug: #1700449 Change-Id: I4405f1bed4c29db32d8d6b35b99915d00baadf44 ** Changed in: neutron-fwaas-dashboard Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1700449 Title: Update firewall rule with a protocol fails Status in OpenStack Dashboard (Horizon): Won't Fix Status in Neutron FWaaS dashboard: Fix Released Bug description: Create a firewall rule via horizon with UDP protocol, and later try to update it to TCP. The Horizon UI will show this error: Error: Failed to update rule non shared rule: Invalid input for protocol. Reason: TCP is not in valid_values. Neutron server returns request_ids: ['req-66afa587-cafb-4e6d-8229-8081e8092437'] and the logs: 2017-06-26 05:35:37.708918 DEBUG:urllib3.connectionpool:http://10.160.90.203:9696 "PUT //v2.0/fw/firewall_rules/507f825b-6798-410f-bab7-41c4dcd7d99b HTTP/1.1" 400 136 2017-06-26 05:35:37.709929 ERROR openstack_dashboard.dashboards.project.firewalls.forms Failed to update rule 507f825b-6798-410f-bab7-41c4dcd7d99b: Invalid input for protocol. Reason: TCP is not in valid_values. 2017-06-26 05:35:37.709938 Neutron server returns request_ids: ['req-66afa587-cafb-4e6d-8229-8081e8092437'] 2017-06-26 05:35:37.710425 WARNING horizon.exceptions Recoverable error: Invalid input for protocol. Reason: TCP is not in valid_values. The reason is that the protocols should be sent to neutron in lower- case. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1700449/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
