Reviewed: https://review.openstack.org/468136
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=452f21183f2f80cc5673ebd3fd3e5daf039caacc
Submitter: Jenkins
Branch: master
commit 452f21183f2f80cc5673ebd3fd3e5daf039caacc
Author: Matt Riedemann <mriedem...@gmail.com>
Date: Thu May 25 15:00:24 2017 -0400
Handle conflict from neutron when addFloatingIP fails
Neutron can raise a Conflict exception when attempting
to associate a floating IP to a server when the fixed
address is already associated to another floating IP.
This has always resulted in a 400 response, however, it
would also trace an ERROR in the nova-api logs, which is
something we shouldn't be doing for an expected type of
failure.
This handles the Conflict in the neutronv2 API client code
and re-raises an exception that the REST API controller code
can handle and return as a 400 without the stacktrace in the
logs.
Change-Id: I27d3241300f75e2aa79a32348a3843e09123cb10
Closes-Bug: #1693576
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1693576
Title:
addFloatingIP conflict is tracing in n-api logs
Status in OpenStack Compute (nova):
Fix Released
Status in OpenStack Compute (nova) newton series:
In Progress
Status in OpenStack Compute (nova) ocata series:
In Progress
Bug description:
This Tempest negative test was added back in March:
https://github.com/openstack/tempest/commit/343ca198166ded0bbf6e23535aeae0ea15a922dc
It passes but it results in an ugly stacktrace in the n-api logs:
http://logs.openstack.org/89/466889/2/gate/gate-tempest-dsvm-neutron-
full-ubuntu-
xenial/57732b0/logs/screen-n-api.txt.gz?level=TRACE#_May_24_07_30_30_975142
Which is normally a place where we shouldn't stacktrace if it's not a
500 error.
This is an expected situation, and we should be able to handle the 409
Conflict from Neutron and translate that to a proper error handled at
the top REST API controller.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1693576/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
