Reviewed: https://review.openstack.org/389314
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=4aa55f3edf453b3baba4efef4cca054f490f2d69
Submitter: Jenkins
Branch: master
commit 4aa55f3edf453b3baba4efef4cca054f490f2d69
Author: Matthew Edmonds <edmon...@us.ibm.com>
Date: Thu Oct 20 14:26:35 2016 -0400
fix os-volume_attachments policy checks
The os-volume_attachments APIs have their own policy settings defined,
yet were also checking the policy settings defined for the os-volumes
APIs. This should never have been the case, but especially not now
that the os-volumes APIs are deprecated and don't even work anymore
with newer microversions. This change removes the os-volumes policy
checks for os-volume_attachment API requests. The code will continue
to make os-volumes policy checks for os-volumes APIs, and
os-volume_attachment policy checks for os-volume_attachment APIs.
Removed the _items method, which was only being called from one place,
to resolve comments that policy checks should always happen immediately
upon entering the API methods.
Change-Id: I35aaedf5c4c49cb568fa06c2974f9a35aa2ffcc5
Closes-Bug: #1635358
UpgradeImpact
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1635358
Title:
os-volume_attachments APIs requiring os-volumes permissions
Status in OpenStack Compute (nova):
Fix Released
Bug description:
The os-volume_attachments APIs (see http://developer.openstack.org
/api-ref/compute/#servers-with-volume-attachments-servers-os-volume-
attachments) have their own policy settings defined, yet are also
checking the policy settings which are defined for the os-volumes APIs
(see http://developer.openstack.org/api-ref/compute/#volume-extension-
os-volumes-os-snapshots-deprecated). This should never have been the
case, but especially not now that the os-volumes APIs have been
deprecated and have even stopped working with newer microversions.
seen in newton
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1635358/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
