Reviewed: https://review.openstack.org/382711 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=91434be160634759407c26c099754ae4e2353958 Submitter: Jenkins Branch: master
commit 91434be160634759407c26c099754ae4e2353958 Author: Dharini Chandrasekar <[email protected]> Date: Thu Oct 6 03:50:42 2016 +0000 Handling scrubber's exit in non-daemon mode. Currently, Scrubber exits with a status code of zero upon job fetching errors both in daemon and non daemon mode. It is more appropriate to have scrubber exit with status code 1 if it is not in daemon mode. This patch causes scrubber to exit with status code 1 (RuntimeError)if the scrubber is not running in daemon mode, facilitating accurate exits. Co-Authored-By: Steve Lewis <[email protected]> Co-Authored-By: Dharini Chandrasekar <[email protected]> Closes-Bug: #1548289 Change-Id: Ib75676dc90349f008395fb118978f4e37fa876ea ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1548289 Title: Scrubber exits with 0 even though it didn't work Status in Glance: Fix Released Bug description: glance-scrubber fails to work with: 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client [req-3200d95d-a3d7-4347-a4a3-9e00dc2fbc53 glance service - - -] Registry client request GET /images/detail raised AuthUrlNotFound 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client Traceback (most recent call last): 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client File "/usr/lib/python2.7/site-packages/glance/registry/client/v1/client.py", line 121, in do_request 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client **kwargs) 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client File "/usr/lib/python2.7/site-packages/glance/common/client.py", line 71, in wrapped 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client return func(self, *args, **kwargs) 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client File "/usr/lib/python2.7/site-packages/glance/common/client.py", line 367, in do_request 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client self._authenticate() 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client File "/usr/lib/python2.7/site-packages/glance/common/client.py", line 345, in _authenticate 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client auth_plugin.authenticate() 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client File "/usr/lib/python2.7/site-packages/glance/common/auth.py", line 131, in authenticate 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client _authenticate(auth_url) 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client File "/usr/lib/python2.7/site-packages/glance/common/auth.py", line 125, in _authenticate 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client self._v1_auth(token_url) 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client File "/usr/lib/python2.7/site-packages/glance/common/auth.py", line 188, in _v1_auth 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client raise exception.AuthUrlNotFound(url=token_url) 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client AuthUrlNotFound: Auth service at URL http://10.164.0.2:5000/v3/tokens not found. 08:52:43 2016-02-21 07:52:43.009 16387 ERROR glance.registry.client.v1.client 08:52:43 2016-02-21 07:52:43.011 16387 ERROR glance.scrubber [req-3200d95d-a3d7-4347-a4a3-9e00dc2fbc53 glance service - - -] Can not get scrub jobs from queue: Auth service at URL http://10.164.0.2:5000/v3/tokens not found. (this was due to using keystone v3 API -- but ignore the error itself, just consider that it failed for some reason) However, when I run it, the exit code of the process is still 0, while it should be 1. To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1548289/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
