Reviewed: https://review.openstack.org/397941 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0a7f3cebec400e2b5fdcea365e451a007a6d0a6f Submitter: Jenkins Branch: master
commit 0a7f3cebec400e2b5fdcea365e451a007a6d0a6f Author: Sivasathurappan Radhakrishnan <siva.radhakrish...@intel.com> Date: Tue Nov 15 20:32:35 2016 +0000 Raise InvalidInput exception If invalid input like v4-fixed-ip is given while creating instance, it raises rescheduled exception as it is not handled. This patch raises invalid input exception and aborts the build of instance. Change-Id: I7c4af81ddbb94dde42e889cdb559b59438cf0231 Closes-bug:1526664 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1526664 Title: wrong error message showing in "nova show inst" if boot an instance with invalid v4-fixed-ip Status in OpenStack Compute (nova): Fix Released Bug description: [Summary] wrong error message showing in "nova show inst" if boot an instance with invalid v4-fixed-ip [Topo] devstack all-in-one node [Description and expect result] should return an error message says that "invalid v4-fixed-ip" [Reproduceable or not] reproduceable [Recreate Steps] 1) create a network/subnet, and boot an instance with invalid v4-fixed-ip: root@45-59:/opt/stack/devstack# neutron net-list | grep net2 | 2de63c95-f645-492c-9197-5d4d5244a8ba | net2 | 47eb5e03-c16a-4303-923c-21a061f2909e 1.0.0.0/24 | root@45-59:/opt/stack/devstack# root@45-59:/opt/stack/devstack# nova boot --flavor 1 --image cirros-0.3.4-x86_64-uec --availability-zone nova --nic net- id=2de63c95-f645-492c-9197- 5d4d5244a8ba,v6-fixed-ip=1.0.0.255 inst (note: 1.0.0.255 is broadcast ip for the network, should be invalid.) 2) wrong error message showing in "nova show inst": root@45-59:/opt/stack/devstack# nova show inst +-------------------------------------- +------------------------------------------------------------------------------------------------------------------------------------------------------------ -------------------------------+ | Property | Value | +-------------------------------------- +------------------------------------------------------------------------------------------------------------------------------------------------------------ -------------------------------+ | OS-DCF:diskConfig | MANUAL | | OS-EXT-AZ:availability_zone | nova | | OS-EXT-SRV-ATTR:host | - | | OS-EXT-SRV-ATTR:hostname | inst | | OS-EXT-SRV-ATTR:hypervisor_hostname | - | | OS-EXT-SRV-ATTR:instance_name | instance-00000015 | | OS-EXT-SRV-ATTR:kernel_id | 0975d828-5725-4044-9477-046b0aa437f4 | | OS-EXT-SRV-ATTR:launch_index | 0 | | OS-EXT-SRV-ATTR:ramdisk_id | dea382c7-c36e-443f-8f9a-a0a6cef56337 | | OS-EXT-SRV-ATTR:reservation_id | r-fwx0mk0q | | OS-EXT-SRV-ATTR:root_device_name | /dev/vda | | OS-EXT-SRV-ATTR:user_data | - | | OS-EXT-STS:power_state | 0 | | OS-EXT-STS:task_state | - | | OS-EXT-STS:vm_state | error | | OS-SRV-USG:launched_at | - | | OS-SRV-USG:terminated_at | - | | accessIPv4 | | | accessIPv6 | | | config_drive | | | created | 2015-12-16T16:10:16Z | | fault | {"message": "No valid host was found. There are not enough hosts available.", "code": 500, "details": " File \"/opt/stack/nova/nova/conductor/manager.py\", line 359, in build_instances | >>>>ISSUE, wrong error message | | request_spec, filter_properties) | | | File \"/opt/stack/nova/nova/scheduler/utils.py\", line 343, in wrapped | | | return func(*args, **kwargs) | | | File \"/opt/stack/nova/nova/scheduler/client/__init__.py\", line 52, in select_destinations | | | context, request_spec, filter_properties) | | | File \"/opt/stack/nova/nova/scheduler/client/__init__.py\", line 37, in __run_method | | | return getattr(self.instance, __name)(*args, **kwargs) | | | File \"/opt/stack/nova/nova/scheduler/client/query.py\", line 34, in select_destinations | | | context, request_spec, filter_properties) | | | File \"/opt/stack/nova/nova/scheduler/rpcapi.py\", line 122, in select_destinations | | | request_spec=request_spec, filter_properties=filter_properties) | | | File \"/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/client.py\", line 158, in call | | | retry=self.retry) | | | File \"/usr/local/lib/python2.7/dist-packages/oslo_messaging/transport.py\", line 90, in _send | | | timeout=timeout, retry=retry) | | | File \"/usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqpdriver.py\", line 464, in send | | | retry=retry) | | | File \"/usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqpdriver.py\", line 455, in _send | | | raise result | | | ", "created": "2015-12-16T16:10:19Z"} | | flavor | m1.tiny (1) | | hostId | | | id | 45e251bf-391e-4238-bbe9-254aeb37346e | | image | cirros-0.3.4-x86_64-uec (8883fa03-0cf2-45a7-bcaf-ff5df9e11016) | | key_name | - | | metadata | {} | | name | inst | | os-extended-volumes:volumes_attached | [] | | status | ERROR | | tenant_id | 6c15aacc1cfe4a9fac35a0c7f8c3e912 | | updated | 2015-12-16T16:10:18Z | | user_id | f701a3a4e9ad4a869e886c84e4dc327e | +-------------------------------------- +------------------------------------------------------------------------------------------------------------------------------------------------------------ -------------------------------+ root@45-59:/opt/stack/devstack# ISSUE: the error message says "No valid host was found. There are not enough hosts available." , but actually the root cause of the error is invalid v4-fixed-ip. [Configration] reproduceable bug, no need [logs] reproduceable bug, no need [Root cause anlyze or debug inf] reproduceable bug [Attachment] None To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1526664/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp