Reviewed: https://review.openstack.org/290706 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0f26569649b5785e18581143f30cd5d44a77c1bf Submitter: Jenkins Branch: master
commit 0f26569649b5785e18581143f30cd5d44a77c1bf Author: Stephen Finucane <[email protected]> Date: Tue Dec 13 13:47:38 2016 +0000 libvirt: Flatten 'get_domain' function Recent changes to the code mean the function 'get_domain' is the sole caller of '_get_domain_by_name'. This structure is unnecessarily bloated and prevents us from raising valid InstanceNotFound exceptions containing Instance.uuid values. Fold the latter functions into the former, shedding this excess weight and partially resolving the bug. Change-Id: I43d608a629b3dba204264f1db97fb35b205aee85 Closes-Bug: #1522454 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1522454 Title: Nova is leaking libvirt internal ids on some Instance Not Found errors Status in OpenStack Compute (nova): Fix Released Bug description: Nova from master in the gate. libvirt is incorrectly using InstanceNotFound as an internal exception, but handing it libvirt internal ids instead of an openstack uuid or ec2id. This means it jumps up through the stack and back to the user, giving errors over http like Instance instance-000000a not found. This is both an information leak, and useless bit of information for the user to figure out what's going on. libvirt should use an internal exception instead. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1522454/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
