Reviewed: https://review.openstack.org/391113 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4a09c2210b3c07343411a06c676c2d85aa0e214f Submitter: Jenkins Branch: master
commit 4a09c2210b3c07343411a06c676c2d85aa0e214f Author: Prashanth kumar reddy <[email protected]> Date: Thu Oct 27 07:09:01 2016 -0400 Separate CRUD policy for server_groups The same policy rule (os_compute_api:os-server-groups) is being used for all actions (show, index, delete, create) for server_groups REST APIs. It is thus impossible to provide different RBAC for specific actions based on roles. To address this changes are made to have separate policy rules for each of action. It has been argued that index and show may not need separate policy rules, but most other places in nova (and OpenStack in general) do have separate policy rules for each action. This affords the ultimate flexibility to deployers, who can obviously use the same rule if that is what they want. One example where show and index may be different is that if show is restricted based on some criteria, such that a user is able to see some resources within the tenant but not others, then list would need to be disallowed to prevent the user from using list to see resources they cannot show. Change-Id: Ica9e07f6e80257902b4a0cc44b65fd6bad008bba Closes-Bug: #1636157 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1636157 Title: os-server-groups uses same policy.json rule for all CRUD operations Status in OpenStack Compute (nova): Fix Released Bug description: All os-server-groups REST calls use same rule (https://github.com/openstack/nova/blob/master/nova/policies/server_groups.py#L29-L31) instead of having a separate rule for create, delete, show and list actions on server_groups. This takes away control of RBAC at a REST api level and is incorrect. Here are the references of rule being used with respective REST action. 1. create (https://github.com/openstack/nova/blob/stable/newton/nova/api/openstack/compute/server_groups.py#L136) 2. delete(https://github.com/openstack/nova/blob/stable/newton/nova/api/openstack/compute/server_groups.py#L89) 3. show (https://github.com/openstack/nova/blob/stable/newton/nova/api/openstack/compute/server_groups.py#L78) 4. list(https://github.com/openstack/nova/blob/stable/newton/nova/api/openstack/compute/server_groups.py#L120) seen in newton To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1636157/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
