Reviewed: https://review.openstack.org/358790 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d7d59b85969acb757f9871535758d75592aae660 Submitter: Jenkins Branch: master
commit d7d59b85969acb757f9871535758d75592aae660 Author: andrewbogott <abog...@wikimedia.org> Date: Mon Aug 22 10:50:38 2016 -0500 Remove all_tenants flag in quota check I don't really know what this was meant to do, but what it actually does doesn't make any sense -- when checking a quota for project 'foo' we really don't care about how many instances are used in the entire cloud, only in project 'foo'. Until Liberty, the all_tenant flag was broken in the nova api, which probably explains why this was harmless until Liberty. Change-Id: I9e12c10951e7518ab1c622a4daac962bad332da5 Closes-Bug: #1610693 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1610693 Title: Broken instances quota check in Liberty Status in OpenStack Dashboard (Horizon): Fix Released Bug description: I have recently upgraded my cluster to Liberty for all projects. Now, when I create new instances, I frequently get an incorrect quota warning from the instance creation workflow, despite having plenty of available quota: "The requested instance cannot be launched as you only have 0 of your quota available." The issue is happening within the _get_tenant_compute_usages() check. That function determines (correctly) that I am able to list instances in all projects, so passes 'all_tenants' to the nova api. That results in an api call that looks like this: "GET /v2/<tenantid>/servers/detail?all_tenants=True&tenant_id=<tenantid> HTTP/1.1" Nova replies with a list of every instance in my entire cloud, 719 at last count. The call is very slow and, of course, 719 is many more than my instance quota for the current project, so Horizon determines that I am over quota. Note that this issue didn't appear when I was running Liberty Horizon with Kilo Nova (so maybe this is a bug or change in the nova-api) Best I can tell, the offending code in Horizon is still present in the git head. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1610693/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp