Reviewed: https://review.openstack.org/373964 Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=9727aacea293f0fd221956471e0a2da2ec8bbf26 Submitter: Jenkins Branch: master
commit 9727aacea293f0fd221956471e0a2da2ec8bbf26 Author: Yushiro FURUKAWA <[email protected]> Date: Wed Sep 21 18:34:04 2016 +0900 Fix an argument for an exception message This commit fixes an argument for following exception messages and also removes unnecessary whitespace in FirewallRuleNotAssociatedWithPolicy. * FirewallRuleNotAssociatedWithPolicy * FirewallRuleAlreadyAssociated Change-Id: If227e250cacfac37735d1b20a24f40c28e637c6e Closes-Bug: #1623102 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1623102 Title: FWaaSv2 - Error message about 'Rule association' is wrong Status in neutron: Fix Released Bug description: When try to firewall_policy insert_rule or remove_rule with invalid request, following error message is displayed: [Error message] { "NeutronError": { "message": "Operation cannot be performed since Firewall Rule 19230148-740b-4546-9d9a-ab0c50178369 is already associated with FirewallPolicy <built-in function id>", "type": "FirewallRuleAlreadyAssociated", "detail": "" } } or { "NeutronError": { "message": "Firewall Rule 19230148-740b-4546-9d9a-ab0c50178369 is not associated with Firewall Policy <built-in function id>.", "type": "FirewallRuleNotAssociatedWithPolicy", "detail": "" } } In fact, <build-in function id> should be ID or name for firewall_policy. [How to reproduce] $ source devstack/openrc admin admin $ export TOKEN=`openstack token issue| grep ' id '| get_field 2` $ curl -s -X PUT -H "content-type:application/json" -d '{"firewall_rule_id": "19230148-740b-4546-9d9a-ab0c50178369"}' -H "x-auth-token:$TOKEN" localhost:9696/v2.0/fwaas/firewall_policies/e84a79af-b16d-4e2d-a36e-ad3cff41dbd3/insert_rule or $ curl -s -X PUT -H "content-type:application/json" -d '{"firewall_rule_id": "19230148-740b-4546-9d9a-ab0c50178369"}' -H "x -auth-token:$TOKEN" localhost:9696/v2.0/fwaas/firewall_policies /e84a79af-b16d-4e2d-a36e-ad3cff41dbd3/remove_rule To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1623102/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
