Reviewed: https://review.openstack.org/367735
Committed:
https://git.openstack.org/cgit/openstack/heat/commit/?id=2a662465361e31dbf230d597182f9f7fd8b61183
Submitter: Jenkins
Branch: master
commit 2a662465361e31dbf230d597182f9f7fd8b61183
Author: Ji-Wei <ji.w...@zte.com.cn>
Date: Fri Sep 9 13:06:26 2016 +0800
Raise NotImplementedError instead of NotImplemented
NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).
NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).
>>> raise NotImplemented()
Traceback (most recent call last):
File "<pyshell#0>", line 1, in <module>
raise NotImplemented()
TypeError: 'NotImplementedType' object is not callable
>>> raise NotImplementedError()
Traceback (most recent call last):
File "<pyshell#1>", line 1, in <module>
raise NotImplementedError()
NotImplementedError
This patch fix it.
Change-Id: I939eaa4b4b7c574f7a6447725e3a6ad5b128f1b7
Closes-Bug: #1339855
** Changed in: heat
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1339855
Title:
Raise NotImplementedError instead of NotImplemented
Status in CloudCafe:
Fix Committed
Status in Fuel for OpenStack:
Fix Committed
Status in heat:
Fix Released
Status in OpenStack Identity (keystone):
Fix Released
Status in keystonemiddleware:
In Progress
Status in neutron:
Fix Released
Status in Solar:
In Progress
Status in Warm:
Invalid
Bug description:
NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).
NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).
It makes no sense to raise a constant. The exception should be raised
instead.
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloudcafe/+bug/1339855/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
