Reviewed: https://review.openstack.org/350661 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=28c443f4e320c4c35b650f0aedb1e6343c785be3 Submitter: Jenkins Branch: master
commit 28c443f4e320c4c35b650f0aedb1e6343c785be3 Author: zarrouk <mzarrouk....@orange.com> Date: Wed Aug 3 17:43:14 2016 +0200 Do not send shared param when not allowed. When a user changes the name of a network, neutron returns a 403 error. Even if the user only changes the name and doesn't change the shared state, Horizon send the shared data to neutron and neutron returns 403 when the user doesn't have admin rights Change-Id: I52726b7215acb877f38069c95d190eb36399954f Closes-Bug: #1609467 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1609467 Title: Rename Network return 403 Error Status in OpenStack Dashboard (Horizon): Fix Released Bug description: When renaming a network, Horizon sends all parameters of the network, even the ones we do not change: curl -i https:/<neutron_endpoint>/v2.0/networks/<net_id>.json -X PUT -H "User-Agent: python-neutronclient" -H "X-Auth-Token: <token>" -d '{"network": {"shared": false, "name": "dfdf", "admin_state_up": true}}' DEBUG: openstack_dashboard.api.neutron network_update 678: network_update(): netid=<net_id>, params={'shared': False, 'name': u'plouf', 'admin_state_up': True} DEBUG: neutronclient.client http_log_req 185: REQ: curl -i https://network.fr1.cloudwatt.com/v2.0/networks/<net_id>.json -X PUT -H "User-Agent: python-neutronclient" -H "X-Auth-Token:<token_id>d" -d '{"network": {"shared": false, "name": "plouf", "admin_state_up": true}}' DEBUG: neutronclient.client http_log_resp 194: RESP: 403 {'Content-Length': '130', 'Keep-Alive': 'timeout=5, max=100', 'Connection': 'Keep-Alive', 'Date': 'Tue, 02 Aug 2016 13:30:11 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=UTF-8', 'X-Openstack-Request-Id': 'req-8593fcfb-835c-4684-b068-068b5e14e4f2'} {"NeutronError": {"message": "Policy doesn't allow update_network to be performed.", "type": "PolicyNotAuthorized", "detail": ""}} DEBUG: neutronclient.v2_0.client _handle_fault_response 247: Error message: {"NeutronError": {"message": "Policy doesn't allow update_network to be performed.", "type": "PolicyNotAuthorized", "detail": ""}} INFO: openstack_dashboard.dashboards.project.networks.forms handle 71: Echec de mise à jour du réseau plouf WARNING: horizon.exceptions handle_recoverable 255: Recoverable error: Policy doesn't allow update_network to be performed. Neutron server returns request_ids: ['req-8593fcfb-835c-4684-b068-068b5e14e4f2'] curl -i https://network.fr1.cloudwatt.com/v2.0/networks/79564170-e563-4b82-b2ac-c5a5bbef3b98.json -X PUT -H "User-Agent: python-neutronclient" -H "X-Auth-Token: c5e5196e85994a468b41919d5fd74fa8" -d '{"network": {"name": "erertrtrtrtrt","admin_state_up": true}}' The api refuses the "shared": false even if it does not change. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1609467/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp