Reviewed: https://review.openstack.org/346269 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7339641fac40787dee8474be5cd6939291d55b0d Submitter: Jenkins Branch: master
commit 7339641fac40787dee8474be5cd6939291d55b0d Author: Tyr Johanson <t...@hp.com> Date: Fri Jul 22 16:53:49 2016 -0600 Allow listFunction extra params --- Includes numerous bug fixes to hz-dynamic-table and friends to be responsive to dynamic table configurations or trackBy expressions. --- Some resource types (like subnets) can only be listed for a given parent container (like networks). This patch modifies the hz-resource-table to allow a user to pass in extra paramters that will be passed to the list function for a given resource type. For example usage: See DNSaaS https://review.openstack.org/#/c/341182/9/designatedashboard/static/designatedashboard/resources/os-designate-recordset/details/zone-recordsets.html For example: This allows hz-resource-table to be used to show a list of subnets as one of the details views for a network. The details view controller passes in the current network ID as an extra paramter to the hz-resource-table, which in turn, supplies that value to the subnets list function. The subnets list function can use the parameters it is given to build the appropriate API call. This is very similar to what already exists to pass server search parameters from magic search to the API in the angular images table. Change-Id: I90c851aef0a452e4e8ef39e938ac3ca67a93cfac Partially-Implements: blueprint angular-registry Closes-Bug: 1608462 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1608462 Title: 'non-assignable' JS error in NG LI Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Seeing the following error in the new Launch Instance wizard in master: angular.js:12783 Error: [$compile:nonassign] Expression '$isAvailableTable ? ctrl.availableTableConfig : ctrl.allocatedTableConfig' in attribute 'config' used with directive 'hzDynamicTable' is non-assignable! http://errors.angularjs.org/1.4.10/$compile/nonassign?p0=%24isAvailableTabl…eTableConfig%20%3A%20ctrl.allocatedTableConfig&p1=config&p2=hzDynamicTable at angular.js:68 at parentSet (angular.js:9137) at parentValueWatch (angular.js:9150) at regularInterceptedExpression (angular.js:14752) at Scope.$digest (angular.js:16194) at Scope.$apply (angular.js:16467) at HTMLAnchorElement.<anonymous> (angular.js:24076) at HTMLAnchorElement.dispatch (jquery.js:5095) at HTMLAnchorElement.elemData.handle (jquery.js:4766) To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1608462/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp