Reviewed: https://review.openstack.org/340724 Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=e2506d11996a7a55ca90860b4345ea3bfa25c0fe Submitter: Jenkins Branch: master
commit e2506d11996a7a55ca90860b4345ea3bfa25c0fe Author: weiweigu <gu.wei...@zte.com.cn> Date: Tue Jul 12 16:33:39 2016 +0800 Fix string interpolation to delayed to be handled by the logging code String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. See the oslo i18n guideline. * http://docs.openstack.org/developer/oslo.i18n/guidelines.html Change-Id: I410acf693d8b7b1677a7f5b1749d9c1a48aaf177 Closes-Bug: #1596829 ** Changed in: os-brick Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1596829 Title: String interpolation should be delayed at logging calls Status in Ceilometer: New Status in Glance: New Status in glance_store: New Status in heat: New Status in Ironic: New Status in OpenStack Identity (keystone): New Status in neutron: Fix Released Status in OpenStack Compute (nova): In Progress Status in os-brick: Fix Released Status in python-cinderclient: New Status in python-glanceclient: In Progress Status in OpenStack Object Storage (swift): New Status in taskflow: New Bug description: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Wrong: LOG.debug('Example: %s' % 'bad') Right: LOG.debug('Example: %s', 'good') See the following guideline. * http://docs.openstack.org/developer/oslo.i18n/guidelines.html #adding-variables-to-log-messages The rule for it should be added to hacking checks. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp