Reviewed: https://review.openstack.org/317619 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1d60ffd5d017c82ea3eeb9b429e0ee5030f5891c Submitter: Jenkins Branch: master
commit 1d60ffd5d017c82ea3eeb9b429e0ee5030f5891c Author: Matt Borland <matt.borl...@hpe.com> Date: Tue May 17 10:38:17 2016 -0600 Added safety check to initActions so unregistered types pass This patch adds a basic safety check to ensure that initScope doesn't throw errors when an unregistered type is passed in. Added a test that demonstrates this as well. Change-Id: Ifdefaa3cc0b792221323136de8b8bd0eb76d7486 Closes-Bug: 1579262 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1579262 Title: Angular registry - Cannot read property 'itemActions' of undefined Status in OpenStack Dashboard (Horizon): Fix Released Status in OpenStack Search (Searchlight): In Progress Bug description: If you attempt to use initActions for a resource type that hasn't been registered, and error is thrown: angular.js:11707 TypeError: Cannot read property 'itemActions' of undefined at Object.initActions (http://127.0.0.1:8005/static/framework/conf/resource-type-registry.service.js:265:42) at http://127.0.0.1:8005/static/dashboard/project/search/table/search-table.controller.js:114:18 at Array.forEach (native) at pluginsUpdated (http://127.0.0.1:8005/static/dashboard/project/search/table/search-table.controller.js:113:33) at Scope.$emit (http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:14798:33) at pluginsReceived (http://127.0.0.1:8005/static/dashboard/project/search/settings/search-settings.service.js:108:15) at http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:9442:11 at processQueue (http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:13300:27) at http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:13316:27 at Scope.$eval (http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:14552:28) Found this when testing the hypervisor plugin for searchlight: https://review.openstack.org/#/c/297586/7 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1579262/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp