Reviewed: https://review.openstack.org/315498
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=9e663477f5d486f1625372c9798142758fbfec90
Submitter: Jenkins
Branch: master
commit 9e663477f5d486f1625372c9798142758fbfec90
Author: Davanum Srinivas <dava...@gmail.com>
Date: Thu May 12 07:36:01 2016 -0400
Avoid testing oslo.service library internals
oslo.service===1.10.0 added a few kwargs with proper defaults. In
our tests we seem to be testing library internals, causing the tests
to fail with the new library version.
As a workaround to unblock the gate, add modified test code
to pass with both the old 1.9.0 and 1.10.0 of the oslo.service
library.
Change-Id: Ife69c319409a4214658bc94498108b8b3c5db8cb
Closes-Bug: #1581325
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1581325
Title:
test_dhcp_agent_main_agent_manager fails in UT
Status in neutron:
Fix Released
Bug description:
We can see UT failure[1]. Oslo.service 1.10.0 caused this error.
ft8.16:
neutron.tests.unit.agent.dhcp.test_agent.TestDhcpAgent.test_dhcp_agent_main_agent_manager_StringException:
Empty attachments:
pythonlogging:''
stderr
stdout
Traceback (most recent call last):
File "neutron/tests/unit/agent/dhcp/test_agent.py", line 287, in
test_dhcp_agent_main_agent_manager
mock.call().wait()])
File
"/home/jenkins/workspace/gate-neutron-python27/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py",
line 969, in assert_has_calls
), cause)
File
"/home/jenkins/workspace/gate-neutron-python27/.tox/py27/local/lib/python2.7/site-packages/six.py",
line 718, in raise_from
raise value
AssertionError: Calls not found.
Expected: [call(<oslo_config.cfg.ConfigOpts object at 0x7fa97c05af10>),
call().launch_service(<ANY>),
call().wait()]
Actual: [call(<oslo_config.cfg.ConfigOpts object at 0x7fa97c05af10>,
restart_method='reload'),
call().launch_service(<neutron.service.Service object at 0x7fa975834750>,
workers=1),
call().wait()]
[1]: http://logs.openstack.org/92/314492/1/gate/gate-neutron-
python27/c2878bb/testr_results.html.gz
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1581325/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
