Reviewed: https://review.openstack.org/299934 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e63b5d86acee7e587829e4a4f581ed8d5a56051f Submitter: Jenkins Branch: master
commit e63b5d86acee7e587829e4a4f581ed8d5a56051f Author: Timur Sufiev <[email protected]> Date: Thu Mar 31 16:35:20 2016 +0300 Make i9n tests correctly recognize the deletion of a last row in a table First, .is_displayed() method inside RowRegion needs to be invoked correctly. Second, we need to distinguish an .empty placeholder row from the last deleted row which contents are replaced with .empty row contents from inside. Otherwise these 2 rows are considered the same by tests. This is done by checking first for empty_table_selector. Change-Id: I1abeb9f5ffc94213011e24eda99bb8a1ca8bfaeb Closes-Bug: #1564405 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1564405 Title: Integration tests don't actually wait until table row is deleted Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Usually it goes unnoticed because objects are deleted at the end of a test (cleanUp phase) - and the deletion manages to finish before the next test is launched, but when a dependent entities A<-B are deleted in order, sometimes not waiting for B to delete leads to failure while deleting A (a good example here is Volume <- Volumes Snapshot). This was caused by too broad exception clause here https://github.com/openstack/horizon/blob/2015.1.0rc2/openstack_dashboard/test/integration_tests/basewebobject.py#L42 (in reality exception was raised due to absence of .is_displayed() method in RowRegion, we had to invoke element.src_elem.is_displayed() in that case). To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1564405/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
