Reviewed: https://review.openstack.org/246343 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=337a1b029a1f144f577a78712413a4182dd525f8 Submitter: Jenkins Branch: master
commit 337a1b029a1f144f577a78712413a4182dd525f8 Author: Mark McLoughlin <mar...@redhat.com> Date: Tue Nov 17 10:17:44 2015 +0000 servicegroup: remove the zookeeper driver We have had a "untested and risky to use in production" log warning message for this driver since Kilo, it is currently broken (see below), there are no obviously active users or contributors, and we are planning on enabling Zookeeper usage by adopting the tooz library. bug #1443910 shows that the driver fails to load because eventlet 0.17 broke evzookeeper by moving _SocketDuckForFd from eventlet.greenio to eventlet.greenio.py2 in commit 449c90a. The 0.17 release was in Feb, 2015. The evzookeeper library hasn't been updated since Sep 2012 and the sole maintainer is the original author of the zookeeper servicegroup driver. The tooz driver spec - Ibf70c2dbe308fc8e4dd277d8c75c4445b3dfce90 - proposes a formal deprecation period for the zk driver, during which existing zk driver users are encouraged to move to tooz. However, given the state of the zk driver, we must conclude that there are no existing users who need a graceful migration path. Removing the driver will avoid potential confusion for new users and simplify the path to adopting tooz. Closes-Bug: #1443910 Closes-Bug: #1414517 Closes-Bug: #1414536 Signed-off-by: Mark McLoughlin <mar...@redhat.com> Change-Id: I2dba71e71b1ed7cf8476e8bfe9481e84be5df128 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1414536 Title: Zookeeper servicegroup driver's get_all() erroneously raises ServiceGroupUnavailable Status in OpenStack Compute (nova): Fix Released Bug description: The Zookeeper servicegroup API driver raises nova.exception.ServiceGroupUnavailable when there are no members in UP state for a group. However, the other two drivers for memcache and DB, return an empty list. Since the Zookeeper driver actually calls its own get_all() method in its is_up() method, there's actually no way the Zookeeper driver was working correctly, since if ServiceGroupUnavailable was raised from is_up(), things would go haywire in many places. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1414536/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp