Reviewed: https://review.openstack.org/167819 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=94358a166ae5796ba5a7278a0883db42b81f12b2 Submitter: Jenkins Branch: master
commit 94358a166ae5796ba5a7278a0883db42b81f12b2 Author: Tomoki Sekiyama <[email protected]> Date: Wed Mar 25 14:32:32 2015 -0400 libvirt: Make behavior of os_require_quiesce consistent Currently, os_require_quiesce metadata is used in two meanings. For volume backed instances, quiescing is always tried on snapshot, and the metadata specifies whether snapshot should be aborted if quiescing is failed. For image backed instances in the libvirt driver, the metadata determines whether quiescing is invoked or not. To make the behaviors consistent, this introduces the same logic as volume backed instances into libvirt image snapshotting. This also fixes AttributeError during live snapshot introduced by commit 4f43bbafa4bfc2ab149d5db4eb55320c1602658b. Change-Id: Iade076c996118e53d085ede9574cdf01c9e97829 Closes-Bug: #1436579 Closes-Bug: #1488565 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1488565 Title: Quiescing instance on live snapshot fails by AttributeError Status in OpenStack Compute (nova): Fix Released Bug description: *Step to reproduce: - Enable live snapshot by adding following lines to nova.conf: [workarounds] disable_libvirt_livesnapshot = False - Boot instance from image with hw_qemu_guest_agent=yes and os_require_quiesce=yes properties. $ glance image-show f22-qga +--------------------------------+--------------------------------------+ | Property | Value | +--------------------------------+--------------------------------------+ | Property 'hw_qemu_guest_agent' | yes | Property 'os_require_quiesce' | yes ... $ nova boot --image f22 --flavor m1.small f22-1 - Create an instance image $ nova image-create f22-1 f22-img - Image creation fails with the following error: File "/opt/stack/nova/nova/objects/image_meta.py", line 103, in from_dict image_meta.get("properties", {})) AttributeError: 'ImageMeta' object has no attribute 'get' Full stack trace is : http://paste.openstack.org/show/427151/ To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1488565/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
